Backend delete functionality with queues by Shrutim1505 · Pull Request #81 · volcano-sh/dashboard

Shrutim1505 · 2025-04-11T14:12:48Z

Description:
This PR introduces the backend implementation for the delete functionality. It includes the necessary route, controller logic, and service integration to handle delete operations securely and efficiently.

Changes Made:

Added DELETE API endpoint in the backend

Implemented controller and service logic for delete operation

Integrated appropriate validations and error handling

Updated documentation (if applicable)

Testing:

Verified delete functionality with valid and invalid inputs

Ensured proper status codes and messages are returned

Confirmed no unintended side effects on other endpoints

volcano-sh-bot · 2025-04-11T14:12:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Shrutim1505 · 2025-04-13T21:41:47Z

/assign @kevin-wangzefeng

Monokaix · 2025-04-21T06:54:57Z

Hi, what's the difference between this and #74 ?

Shrutim1505 · 2025-04-21T12:40:07Z

closed that one @Monokaix , this is the correct implementation of backend

Shrutim1505 · 2025-04-21T12:43:14Z

this could be merged after #80

JesseStutler · 2025-04-30T01:48:45Z

Need to solve merge conflicts and add more details in the description, besides, add more screenshot of the effect will be better

Shrutim1505 · 2025-04-30T02:44:42Z

This will be resolved after #80

JesseStutler · 2025-05-07T01:21:41Z

Also need to solve this PR's conflict and give more details for the description

Shrutim1505 · 2025-05-08T13:18:53Z

Also need to solve this PR's conflict and give more details for the description

@JesseStutler this PR is behind #80 so it would be resolved after merge of 80

Monokaix · 2025-05-13T02:01:30Z

Please solve the code conflicts.

Shrutim1505 · 2025-05-13T06:53:33Z

cc : @Monokaix @JesseStutler @kevin-wangzefeng

Monokaix · 2025-05-17T02:33:08Z

Does this pr include delete all resources or just pod and queue?

Shrutim1505 · 2025-05-17T06:01:12Z

@Monokaix it is just for queues, but same logic will be implemented with pods and jobs too

Shrutim1505 · 2025-05-17T06:01:30Z

while restructuring the code i will implement that in jobs and pods too till then we can merge this one

JesseStutler · 2025-05-19T01:23:46Z

I will test it today

JesseStutler · 2025-05-19T02:22:17Z

There is no permission for dashboard to delete the queues, you should also add a delete in dashboard's clusterrole, otherwise api-server will reject dashboard's deleting request:

dashboard/deployment/volcano-dashboard.yaml

Lines 124 to 129 in bad5ca3

    
           resources: 
        
             - queues 
        
           verbs: 
        
             - get 
        
             - list 
        
             - watch

@Shrutim1505

JesseStutler · 2025-05-19T02:27:55Z

Also the error message in the pic is not correct, should be like: Can not delete queue "queue-a", the error is: xxx. And we should not show the CANCEL/DELETE button when we meet errors @Shrutim1505

Shrutim1505 · 2025-05-19T04:45:20Z

Also the error message in the pic is not correct, should be like: Can not delete queue "queue-a", the error is: xxx. And we should not show the CANCEL/DELETE button when we meet errors @Shrutim1505

i will check

Shrutim1505 · 2025-05-19T05:15:28Z

hi @JesseStutler I guess u can check it now

JesseStutler · 2025-05-19T06:09:07Z

There is no permission for dashboard to delete the queues, you should also add a delete in dashboard's clusterrole, otherwise api-server will reject dashboard's deleting request:

dashboard/deployment/volcano-dashboard.yaml

Lines 124 to 129 in bad5ca3

resources:

- queues

verbs:

- get

- list

- watch

@Shrutim1505

@Shrutim1505 You should also add a delete permission for queue in clusterrole

de6p · 2025-05-19T06:10:35Z

@Shrutim1505 Error msg can be improved here though.

Shrutim1505 · 2025-05-19T06:16:23Z

@JesseStutler added

JesseStutler · 2025-05-19T06:21:31Z

deployment/volcano-dashboard.yaml

    namespace: volcano-system
 ---

-# volcano dashboard cluster role


This comment should not added

JesseStutler · 2025-05-19T06:23:44Z

deployment/volcano-dashboard.yaml

      - get
      - list
      - watch
+      - delete


I think dashboard should not have permission to delete namespace

removed @JesseStutler

JesseStutler · 2025-05-19T06:24:32Z

deployment/volcano-dashboard.yaml

      - get
      - list
      - watch
+      - delete


Maybe we can add delete for jobs/pods later? Because your PR only support to delete queues currently

JesseStutler · 2025-05-19T06:25:09Z

frontend/src/components/Searchbar.jsx

                                size="sm"
                                className="rounded-pill px-4 py-2 d-flex align-items-center justify-content-center shadow-sm fw-medium border-2"
-                                onClick={handleRefresh}
+                                onClick={handleRefresh} // This is correct


What is this comment used for?

removed, i guess too its not necessary

JesseStutler · 2025-05-19T06:28:50Z

backend/src/server.js

+        });
+    }
+});
+// Delete a Pod


This PR also support delete pods? But seems that pod doesn't have much error cases such as 4XX? Do we need to support pod deletion in this PR?

POD and job deletion would be completed in next PR @JesseStutler

JesseStutler · 2025-05-19T06:30:06Z

backend/src/server.js

+        const queueName = name.toLowerCase();
+
+        /* ---------- 1. Protect the default queue ---------- */
+        if (queueName === "default") {


Also should protect root queue

ok i will add this too

JesseStutler · 2025-05-19T07:54:42Z

backend/src/server.js

+    } catch (error) {
+        console.error("Error deleting queue:", error?.body || error);
+
+        if (error.statusCode === 403) {


I have a question: Why not directly return the error code and error message to the user? Why do we need to judge based on the different types of codes?

this is just printing type of error in the terminal

We can directly return the error code and error message from kube-apiserver to the user, I think user who are using volcano and k8s will understand the error message, there is no need to judge here and wrap the message

JesseStutler · 2025-05-19T07:55:34Z

backend/src/server.js

+            });
+        }
+
+        if (error.body?.includes("admission webhook")) {


It's very strange to judge based on the return value of the body

@JesseStutler When you try to delete a queue, Kubernetes may have a safety‑check (an admission webhook) that says “No, this queue is protected.”
The API’s error message usually contains the words “admission webhook.”

#81 (comment)

JesseStutler · 2025-05-20T08:37:46Z

backend/src/server.js

+
+    // Disallow deleting protected system queues
+    if (["root", "default"].includes(queueName)) {
+        return res.status(400).json({


I think the return code should be 403

Shrutim1505 · 2025-05-20T09:43:25Z

@JesseStutler @Monokaix please review

JesseStutler · 2025-05-20T11:03:09Z

Please clean your commit message:

JesseStutler · 2025-05-20T11:22:51Z

The current display effect is still incorrect. If the deletion fails, a dialog should be displayed, showing the error message returned from the kube-apiserver. This dialog can be closed( A × button can be showed). Currently, the floating message "Queue "queue-a" cannot be deleted." has been at the top and has not disappeared. @Shrutim1505

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> undo formatting of contributing.md Signed-off-by: Sayan Banerjee <sayanbanerjee2002@gmail.com> update sidebar ui/ux Signed-off-by: Karan Yadav <xpresskaran98@gmail.com> fix deprecated package volcano-sh#46 Signed-off-by: Karan Yadav <xpresskaran98@gmail.com> final rebased commited changes to code-modularity Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> format checker Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> backend working Signed-off-by: Sayan Banerjee <sayanbanerjee2002@gmail.com> refractored code for better UI design Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> refracted ui queues Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> maintain code reusability and improve UI Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> removed package-lock.json from individual workspaces Signed-off-by: Sayan Banerjee <sayanbanerjee2002@gmail.com> undo formatting of contributing.md Signed-off-by: Sayan Banerjee <sayanbanerjee2002@gmail.com> update sidebar ui/ux Signed-off-by: Karan Yadav <xpresskaran98@gmail.com> fix deprecated package volcano-sh#46 Signed-off-by: Karan Yadav <xpresskaran98@gmail.com> format checker Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> configure vitest Signed-off-by: Karan Yadav <xpresskaran98@gmail.com> feat/trpc: Add support for trpc and improve the api response time Signed-off-by: Kuldeep <de6p97@gmail.com> Revert "feat/trpc: Add support for trpc and improve the api response time 5x-10x faster" Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> docker error solve Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> implemented delete and update functionality with all conflicts resolved Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> Add security context configuration Signed-off-by: jessestutler <chenzicong4@huawei.com> Frontend changes of Jobs and Pods UI Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> Frontend updation of the Queues UI Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> Frontend updation of the Queues UI Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> modified jobs-pods for the UI Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> prettier check added Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> edit dialogue box changed Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> pods handle search improved Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> npm run format Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> backend delete queue UI Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> Frontend updation of the Queues UI Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> Frontend updation of the Queues UI Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> modified jobs-pods for the UI Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com> backend on updating queue/job status Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> delete functionality working Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> updated missing functionalities Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> format checker Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> handling error cases Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> delete permission in cluster role Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> refractoring of backend Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> refractoring of backend Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> backend error functionality handling Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com> Delete dialogue on showing error Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com>

Shrutim1505 · 2025-05-20T13:07:44Z

Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com>

volcano-sh-bot requested review from kevin-wangzefeng and william-wang April 11, 2025 14:12

volcano-sh-bot added the size/XXL label Apr 11, 2025

Shrutim1505 force-pushed the backend-update-functionality branch from 184c33b to 2c4ed56 Compare April 13, 2025 21:41

volcano-sh-bot assigned kevin-wangzefeng Apr 13, 2025

Shrutim1505 changed the title ~~Backend update functionality~~ Backend delete functionality Apr 13, 2025

Shrutim1505 mentioned this pull request May 12, 2025

☂ Umbrella issue: Track of Volcano Dashboard Feature Enhancements(LFX'25 term 1) #57

Closed

13 tasks

Shrutim1505 force-pushed the backend-update-functionality branch 2 times, most recently from f26c978 to 611afc9 Compare May 13, 2025 06:51

Shrutim1505 changed the title ~~Backend delete functionality~~ Backend delete functionality with queues May 17, 2025

Shrutim1505 force-pushed the backend-update-functionality branch from 962a789 to ca1123d Compare May 19, 2025 05:14

Shrutim1505 force-pushed the backend-update-functionality branch from abf0056 to c277111 Compare May 19, 2025 06:15

JesseStutler reviewed May 19, 2025

View reviewed changes

Shrutim1505 force-pushed the backend-update-functionality branch 2 times, most recently from 5f4756f to 5c73330 Compare May 19, 2025 08:41

JesseStutler reviewed May 20, 2025

View reviewed changes

Shrutim1505 force-pushed the backend-update-functionality branch from 39d4729 to 68dd27f Compare May 20, 2025 09:42

Shrutim1505 force-pushed the backend-update-functionality branch 5 times, most recently from 7643b48 to 7468516 Compare May 20, 2025 13:05

Shrutim1505 force-pushed the backend-update-functionality branch from 7468516 to ac03d47 Compare May 20, 2025 13:06

Shrutim1505 added 3 commits May 20, 2025 13:16

Backend for deleting queues

5db5a81

Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com>

package.json Backend for deleting queues

c929905

Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com>

backend- final

bc030d4

Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com>

Shrutim1505 closed this May 22, 2025

Conversation

Shrutim1505 commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

volcano-sh-bot commented Apr 11, 2025

Uh oh!

Shrutim1505 commented Apr 13, 2025

Uh oh!

Monokaix commented Apr 21, 2025

Uh oh!

Shrutim1505 commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shrutim1505 commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JesseStutler commented Apr 30, 2025

Uh oh!

Shrutim1505 commented Apr 30, 2025

Uh oh!

JesseStutler commented May 7, 2025

Uh oh!

Shrutim1505 commented May 8, 2025

Uh oh!

Monokaix commented May 13, 2025

Uh oh!

Shrutim1505 commented May 13, 2025

Uh oh!

Monokaix commented May 17, 2025

Uh oh!

Shrutim1505 commented May 17, 2025

Uh oh!

Shrutim1505 commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JesseStutler commented May 19, 2025

Uh oh!

JesseStutler commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JesseStutler commented May 19, 2025

Uh oh!

Shrutim1505 commented May 19, 2025

Uh oh!

Shrutim1505 commented May 19, 2025

Uh oh!

JesseStutler commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

de6p commented May 19, 2025

Uh oh!

Shrutim1505 commented May 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Shrutim1505 commented Apr 11, 2025 •

edited

Loading

Shrutim1505 commented Apr 21, 2025 •

edited

Loading

Shrutim1505 commented Apr 21, 2025 •

edited

Loading

Shrutim1505 commented May 17, 2025 •

edited

Loading

JesseStutler commented May 19, 2025 •

edited

Loading

JesseStutler commented May 19, 2025 •

edited

Loading

JesseStutler commented May 20, 2025 •

edited

Loading