-
Notifications
You must be signed in to change notification settings - Fork 104
docs: improve README with fixes, new sections and updated instructions #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,8 @@ | ||||||
| [](https://app.netlify.com/sites/kind-montalcini-bed86a/deploys) | ||||||
|
|
||||||
|
|
||||||
| # Creating and updating the docs | ||||||
| # Creating and updating the docs | ||||||
|
|
||||||
| Welcome to the GitHub repository for Volcano's public website. The docs are | ||||||
| hosted at https://volcano.sh. | ||||||
|
|
||||||
|
|
@@ -11,96 +12,126 @@ is an open-source static site generator that provides us with templates, content | |||||
| organisation in a standard directory structure, and a website generation engine. | ||||||
| You write the pages in Markdown, and Hugo wraps them up into a website. | ||||||
|
|
||||||
| * Please see [How to contributing](https://github.com/volcano-sh/volcano/blob/master/contribute.md) for instructions on how to contribute, if you are not familiar with the | ||||||
| * Please see [How to contribute](https://github.com/volcano-sh/volcano/blob/master/contribute.md) for instructions on how to contribute, if you are not familiar with the | ||||||
| GitHub workflow | ||||||
|
|
||||||
| ## Quickstart | ||||||
| ## Project Structure | ||||||
|
|
||||||
| Here's a quick guide to updating the docs. It assumes you're familiar with the | ||||||
| GitHub workflow and you're happy to use the automated preview of your doc | ||||||
| updates: | ||||||
| - `content/`: Contains the markdown content for the website. | ||||||
| - `layouts/`: Contains HTML templates for the site structure. | ||||||
| - `static/`: Contains static assets like images, CSS, and JavaScript. | ||||||
| - `themes/`: Contains the site themes (e.g., `docsy`). | ||||||
| - `i18n/`: Contains internationalization files. | ||||||
|
|
||||||
| 1. Fork the repo on GitHub. | ||||||
| 1. Make your changes and send a pull request (PR). | ||||||
| 1. If you're not yet ready for a review, add a comment to the PR saying it's a | ||||||
| work in progress or add `[WIP]` in your PRs title. You can also add `/hold` in a comment to mark the PR as not | ||||||
| ready for merge. (**Don't** add the Hugo declarative "draft = true" to the | ||||||
| page front matter, because that will prevent the auto-deployment of the | ||||||
| content preview described in the next point.) | ||||||
| 1. Wait for the automated PR workflow to do some checks. When it's ready, | ||||||
| you should see a comment like this: **deploy/netlify — Deploy preview ready!** | ||||||
| 1. Click **Details** to the right of "Deploy preview ready" to see a preview | ||||||
| of your updates. | ||||||
| 1. Continue updating your doc until you're happy with it. | ||||||
| 1. When you're ready for a review, add a comment to the PR and assign a | ||||||
| reviewer/approver. | ||||||
|
|
||||||
| ## Previewing your changes on a local website server | ||||||
| ## Local Development | ||||||
|
|
||||||
| If you'd like to preview your doc updates as you work, you can install Hugo | ||||||
| and run a local server. This section shows you how. | ||||||
|
|
||||||
| ### Install Hugo | ||||||
|
|
||||||
| See the [Hugo installation guide][hugo-install]. Here are some examples: | ||||||
| See the [Hugo installation guide][hugo-install]. You generally need the **extended** version of Hugo. | ||||||
|
|
||||||
| #### Mac OS X: | ||||||
| #### Mac OS X | ||||||
|
|
||||||
| ``` | ||||||
| ```bash | ||||||
| brew install hugo | ||||||
| ``` | ||||||
|
|
||||||
| #### Debian: | ||||||
| #### Windows | ||||||
|
|
||||||
| 1. Download the Debian package from the [Hugo website][hugo-install]. | ||||||
| Make sure to install the Hugo version specified by the `HUGO_VERSION` environment variable in the [`netlify.toml`](netlify.toml#L6) file. | ||||||
| For example, [hugo_0.57.2_Linux-64bit.deb][hugo_0.57.2_Linux-64bit.deb]. | ||||||
| 1. Install the package using `dpkg`: | ||||||
| You can use [Chocolatey](https://chocolatey.org/): | ||||||
|
|
||||||
| ``` | ||||||
| sudo dpkg -i hugo_0.57.2_Linux-64bit.deb | ||||||
| ``` | ||||||
| ```powershell | ||||||
| choco install hugo-extended | ||||||
| ``` | ||||||
|
|
||||||
| Or [Scoop](https://scoop.sh/): | ||||||
|
|
||||||
| 1. Verify your installation: | ||||||
| ```powershell | ||||||
| scoop install hugo-extended | ||||||
| ``` | ||||||
|
|
||||||
| #### Linux (Debian/Ubuntu) | ||||||
|
|
||||||
| 1. Download the latest extended .deb package from the [Hugo releases page](https://github.com/gohugoio/hugo/releases). | ||||||
| 2. Install using `dpkg`: | ||||||
|
|
||||||
| ```bash | ||||||
| sudo dpkg -i hugo_extend_x.y.z_Linux-64bit.deb | ||||||
| ``` | ||||||
|
|
||||||
| 3. Verify your installation: | ||||||
|
|
||||||
| ```bash | ||||||
| hugo version | ||||||
| ``` | ||||||
|
|
||||||
| ### Run a local website server | ||||||
|
|
||||||
| Follow the usual GitHub workflow to fork the repo on GitHub and clone it to your | ||||||
| local machine, then use your local repo as input to your Hugo web server: | ||||||
| local machine, then use your local repo as input to your Hugo web server. | ||||||
|
|
||||||
| 1. Ensure you are in your target branch: | ||||||
| 1. Ensure you are in the project root directory: | ||||||
|
|
||||||
| ``` | ||||||
| ```bash | ||||||
| git branch | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The command
Suggested change
|
||||||
| ``` | ||||||
|
|
||||||
| 1. Start your website server. Make sure you run this command from the | ||||||
| `/website/` directory, so that Hugo can find the config files it needs: | ||||||
| 2. Start your website server: | ||||||
|
|
||||||
| ``` | ||||||
| ```bash | ||||||
| hugo server -D | ||||||
| ``` | ||||||
|
|
||||||
| 1. Your website is at [http://localhost:1313/](http://localhost:1313/). | ||||||
| 3. Your website is at [http://localhost:1313/](http://localhost:1313/). | ||||||
|
|
||||||
| 1. Continue with the usual GitHub workflow to edit files, commit them, push the | ||||||
| 4. Continue with the usual GitHub workflow to edit files, commit them, push the | ||||||
| changes up to your fork, and create a pull request. (See the GitHub workflow) | ||||||
|
|
||||||
| 1. While making the changes, you can preview them on your local version of the | ||||||
| 5. While making the changes, you can preview them on your local version of the | ||||||
| website at [http://localhost:1313/](http://localhost:1313/). Note that if you | ||||||
| have more than one local git branch, when you switch between git branches the | ||||||
| local website reflects the files in the current branch. | ||||||
|
|
||||||
| ## Quickstart Contribution Guide | ||||||
|
|
||||||
| 1. Fork the repo on GitHub. | ||||||
| 2. Make your changes and send a pull request (PR). | ||||||
| 3. If you're not yet ready for a review, add a comment to the PR saying it's a | ||||||
| work in progress or add `[WIP]` in your PR's title. You can also add `/hold` in a comment to mark the PR as not | ||||||
| ready for merge. (**Don't** add the Hugo declarative "draft = true" to the | ||||||
| page front matter, because that will prevent the auto-deployment of the | ||||||
| content preview described in the next point.) | ||||||
| 4. Wait for the automated PR workflow to do some checks. When it's ready, | ||||||
| you should see a comment like this: **deploy/netlify — Deploy preview ready!** | ||||||
| 5. Click **Details** to the right of "Deploy preview ready" to see a preview | ||||||
| of your updates. | ||||||
| 6. Continue updating your doc until you're happy with it. | ||||||
| 7. When you're ready for a review, add a comment to the PR and assign a | ||||||
| reviewer/approver. | ||||||
|
|
||||||
| ## Troubleshooting | ||||||
|
|
||||||
| ### 'hugo' not found | ||||||
| Ensure Hugo is in your system PATH. If you installed via a package manager, this should be automatic. | ||||||
|
|
||||||
| ### Images not loading | ||||||
| Make sure image paths in markdown do not start with `/website/` or other subdirectories unless they exist. Use absolute paths starting with `/` which resolve to the `static/` directory. | ||||||
|
|
||||||
| ## Getting Help | ||||||
|
|
||||||
| If you need help or have questions, you can reach out to the community: | ||||||
|
|
||||||
| - **Slack**: Join the Volcano workspace [here](https://volcano-sh.slack.com/). | ||||||
| - **Mailing List**: Subscribe to the [Volcano mailing list](https://groups.google.com/g/volcano-sh). | ||||||
| - **GitHub Issues**: Open an issue in this repository. | ||||||
|
|
||||||
| Useful Hugo docs: | ||||||
| - [Hugo installation guide](https://gohugo.io/getting-started/installing/) | ||||||
| - [Hugo basic usage](https://gohugo.io/getting-started/usage/) | ||||||
| - [Hugo site directory structure](https://gohugo.io/getting-started/directory-structure/) | ||||||
| - [hugo server reference](https://gohugo.io/commands/hugo_server/) | ||||||
| - [hugo new reference](https://gohugo.io/commands/hugo_new/) | ||||||
|
|
||||||
| [hugo-install]: https://gohugo.io/getting-started/installing/ | ||||||
| [hugo_0.57.2_Linux-64bit.deb]: https://github.com/gohugoio/hugo/releases/download/v0.57.2/hugo_0.57.2_Linux-64bit.deb | ||||||
| [hugo-install]: https://gohugo.io/getting-started/installing/ | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small typo in the filename. The package name for the extended version of Hugo is
hugo_extended_..., nothugo_extend_.... The current command will fail when a user tries to execute it.