-
Notifications
You must be signed in to change notification settings - Fork 17
RFC for support of .node-version file #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreassjoberg
wants to merge
5
commits into
volta-cli:main
Choose a base branch
from
andreassjoberg:dot-node-version-file-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| - Feature Name: dot_node_version_file_support | ||
| - Start Date: 2025-03-04 | ||
| - RFC PR: (leave this empty) | ||
| - Volta Issue: (leave this empty) | ||
|
|
||
| # Summary | ||
| [summary]: #summary | ||
|
|
||
| Introduce support for a `.node-version` file, enabling it as a fallback source for determining project-specific Node versions. If Node version is not specified in `package.json`, fallback to `.node-version` before using global defaults. | ||
|
|
||
| # Motivation | ||
| [motivation]: #motivation | ||
|
|
||
| The aim is to align Volta with other popular Node version managers like [mise](https://github.com/jdx/mise), [fnm](https://github.com/Schniz/fnm), [n](https://github.com/tj/n) and [asdf](https://github.com/asdf-vm/asdf-nodejs), which support `.node-version`. This enhances flexibility and user experience by allowing developers to specify their preferred Node versions in a widely recognized format. | ||
| A list of supporting products can be found here: <https://github.com/shadowspawn/node-version-usage> | ||
|
|
||
| # Pedagogy | ||
| [pedagogy]: #pedagogy | ||
|
|
||
| Existing Node developers are likely already familiar with different Node versioning methods. Introducing support for `.node-version` aligns Volta with other Node version managers. | ||
|
|
||
| # Details | ||
| [details]: #details | ||
andreassjoberg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ## Compatible file format | ||
|
|
||
| The contents of `.node-version` will be: | ||
|
|
||
| - optionally a leading `v` | ||
| - three part numeric version (e.g. 20.18.2) | ||
| - optionally a trailing newline (either Unix style or Windows style line endings are allowed) | ||
|
|
||
| Any content found in addition to the above will result in an error message explaining that the `.node-version` file is malformed. | ||
|
|
||
| A leading `v` is widely supported, so this will work with most implementations: | ||
|
|
||
| ```sh | ||
| $ node --version | ||
| v20.18.2 | ||
| $ node --version > .node-version | ||
| ``` | ||
|
|
||
| It is recommended to support optional leading `v` and any line ending [[reference](https://github.com/shadowspawn/node-version-usage#suggested-compatible-format)]. | ||
| Allowing a leading `v` is common and gives a nice symmetry with `node --version`. | ||
| Allowing any line ending makes it easier for users and especially Windows users to create a compatible file. | ||
|
|
||
andreassjoberg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ### Invalid `.node-version` | ||
|
|
||
| When an invalid `.node-version` is found (see [Compatible file format](#compatible-file-format)), Volta will emit an error indicating, as best as we can tell, what is wrong with the file, along with it's file path. _(Implementation note: this could either be relative path or absolute path.)_ | ||
|
|
||
| Primary error cases: | ||
|
|
||
| - Invalid semver range (e.g. `lts/*` or `20`) | ||
| - Unsupported content (leading content, trailing content, etc) | ||
|
|
||
| > The .node-version file at _\<path\>_ is malformed | ||
|
|
||
| ## Inheritance from current solution | ||
|
|
||
| The new feature will act as a fallback when resolving Node version, if `package.json` does not have a `volta` section specifying the Node version. | ||
|
|
||
| ## Standardized Approach | ||
|
|
||
| This implementation should mirror the behavior of other Node version managers, ensuring Volta remains competitive and user-friendly. | ||
|
|
||
| ## Lookup Hierarchy | ||
|
|
||
| The Node version lookup process should follow the order described: | ||
|
|
||
| 1. Resolve `package.json` and check its `volta.node` field. | ||
| 1. Check for the presence of `.node-version`. | ||
| 1. Fallback to the default active Node toolchain. | ||
|
|
||
| ## Backward Compatibility | ||
|
|
||
| This feature does not disrupt current functionality and can be released immediately without breaking changes. | ||
|
|
||
| ## Implementation Considerations | ||
|
|
||
| Ensure the implementation respects the same environment inheritance as today’s solution when reading versions from `package.json`. | ||
| Maintain consistent behavior across different scenarios, ensuring that if no specific version is found in either `package.json` or `.node-version`, Volta defaults to its standard global setting. | ||
|
|
||
| No new commands are required; this feature should integrate seamlessly with existing Volta commands. | ||
|
|
||
| ## Testing Strategy | ||
|
|
||
| Develop comprehensive tests that cover various scenarios, including: | ||
|
|
||
| - Presence and absence of `.node-version`. | ||
| - Conflicting versions between `.node-version` and `package.json`. | ||
| - Interaction with global Node version settings. | ||
|
|
||
| # Critique | ||
| [critique]: #critique | ||
|
|
||
| By supporting `.node-version`, Volta will provide users with more flexibility in how they manage their Node environments, while maintaining its commitment to backward compatibility. This RFC invites feedback on the proposed implementation and any potential edge cases that might arise. | ||
|
|
||
| # Unresolved questions | ||
| [unresolved]: #unresolved-questions | ||
andreassjoberg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| Should we also support `.nvmrc`? | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.