Open
Conversation
Author
|
Anything I can do to help this along? I've just been manually installing curl after startup, but would love to stop doing that. |
Member
|
@edrude 👋 it's me again! I will have to do some CI cleanup. I think curl makes sense in the container. I will take another look when CI passes again. |
Contributor
|
curl in production containers is not really best-pratice IMHO. Any code/tool that is not really necessary should not go in a production container. Maybe there is a better way to use HEALTHCHECK. Or is HEALTHCHECK even necessary in the first place? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using podman on RHEL 9 the health check has always failed for me. If I manually attach to the container and install curl then the health check works again. This pull request adds install curl to the dockerfile so that it will be available for use with the health check.