IndexManager clean #793
Merged
IndexManager clean #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from most places, fix unit testing
Contributor
Author
|
Discount TPTP: |
mezpusz
commented
Dec 10, 2025
Indexing/IndexManager.cpp
Outdated
| * IMPORTANT: Keep these values distinct from each other! | ||
| */ | ||
| void IndexManager::provideIndex(IndexType t, Index* index) | ||
| INDEX_ID_IMPL(AlascaIndex<ALASCA::Demodulation::Lhs>, 0) |
Contributor
Author
There was a problem hiding this comment.
If someone has a better idea to implement this, please let me know. I looked at solution like this and the one in the comments but they don't seem to work for all compilers/linkers.
Contributor
Author
|
Regression over TPTP, induction&synthesis benchmarks and SMTLIB showed essentially no difference (1 lost in induction, 2 lost and 1 gained in SMTLIB). I think the PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some type safety to
IndexManager, such that the matching the index enum values and casted-to index type does not have to be done by the caller. There is still some risk, namely that we map index types to the same values, but I hope that this will be solved by some upcoming feature of C++20/23 where there areconstexprtype IDs and other nice things.The other improvement is that now
IndexManagercannot be supplied from the outside toSaturationAlgorithmwhich allows for using the actualIndexManagerinstance during unit testing instead of the hackysetTestIndices.Regression is TBD, but there shouldn't be anyting drastic.
Otter TPTP:
master unsat: 10299 (0) sat: 1020 (0)
branch unsat: 10300 (1) sat: 1020 (0)