fix crash with sas=z3 and duplicate literals in split clauses #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quickbeam123
force-pushed
the
michael-propinf-crash
branch
from
94943d1 to
f32486b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes AVATAR derives a split clause like
17 | 17and then simplifies it to17. All well and good, but this messes up our proof printing because we assumed that all the SAT premises areFO_CONVERSIONSAT inferences, and17is aPROP_INF.We could also not simplify the clause in AVATAR. This might be nicer as there's already code to handle this ugly case elsewhere in
Splitterand I don't think the SAT/SMT solvers care. But this would be more invasive.