remove SmartPtr in favour of std::unique_ptr or std::shared_ptr #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have this
SharedPtrthing, but it's essentiallystd::shared_ptrwith extra hazard. Remove it.Some of the occurrences were essentially
std::unique_ptr, which is good news, we can save some cycles there. Still to do:check thatthey probably don't really, but it would be a huge changeResultSubstitutionSPreally needs to be sharedusestd::make_sharedwhere possibleAlso: remove some extraneous includes from header files and then fix up the resulting missing includes elsewhere. And the sanitiser was complaining correctly about a null dereference in the
TPTPparser.