Merged
Conversation
Contributor
Author
|
|
Contributor
Author
|
仕様誤解。修正中・・・ |
Contributor
Author
|
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns SpringBone limit functionality with gizmo specifications by updating angle calculations and variable naming conventions. The changes ensure consistent behavior between the visual gizmo representation and the underlying logic.
- Updated angle calculation logic by halving angle values (0.5 multiplier)
- Renamed variables for clarity: m_angleLimitRotation → m_limitSpaceOffset, m_angleLimitAngle1 → m_phi, m_angleLimitAngle2 → m_theta
- Enhanced gizmo visualization with improved phi/theta angle displays and updated theta range to pi/2 with initial value 0
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Vrm10Importer.cs | Updates field assignments to use new variable names during SpringBone import |
| Vrm10Exporter.cs | Updates field references to use new variable names during SpringBone export |
| VRM10SpringBoneJoint.cs | Renames member variables and updates theta range constraint |
| VRM10SpringBoneJointEditor.cs | Updates editor to use new variable names and enhances gizmo visualization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Assets/VRM10/Editor/Components/SpringBone/VRM10SpringBoneJointEditor.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
notargs
approved these changes
Oct 2, 2025
| private SerializedProperty m_angleLimitAngle1; | ||
| private SerializedProperty m_angleLimitAngle2; | ||
| private SerializedProperty m_angleLimitPitch; | ||
| private SerializedProperty m_angleLimitYaw; |
| } | ||
| } | ||
|
|
||
| static void DrawSpace(Matrix4x4 limitSpace, float size) |
Contributor
There was a problem hiding this comment.
ナイス関数化 👍
[質問]ここでいう Space は何を指していますか？
| ); | ||
| } | ||
|
|
||
| private static void DrawSpherical(in Vector3 limit_tail_pos, float pitch, float yaw) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ロジックを修正した。( 角度を 0.5 倍 )=> gizmo の方を修正phi, thetapitch, yaw(Sphericalの第２角度) が見た目に分かるように gizmo を増やした