rutils.iter: fix defclause-sequence drivers #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults `step` in `return-seq-code` to 1. Currently, all drivers that use `defclause-sequence` are broken, because `step` is not bound before `return-sequence-code` is called. This results in `step` being bound to nil, which means `initial-value` is set to `(- nil)` and `step-code` is set to something like `(+ index nil)`. This change causes `step` to default to 1 if it is not provided.
corderguy
force-pushed
the
fix-in-sequence
branch
from
0e8b548 to
14668c3
Compare
corderguy
changed the title
|
@jcguy Thanks for the change! I added a lot of tests from the traditional ITERATE system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults
stepinreturn-seq-codeto 1.Currently, all drivers that use
defclause-sequenceare broken, becausestepis not bound beforereturn-sequence-codeis called. This results instepbeing bound to nil, which meansinitial-valueis set to(- nil)andstep-codeis set to something like(+ index nil). This change causesstepto default to 1 if it is not provided.Fixes #61 #67