Skip to content

Conversation

@bdudabeecoded
Copy link

  • Move uc.js loading to head.html to ensure loading after default consent

What problem is this solving?

Default consent should be configured prior to loading the consent application

How should this be manually tested?

  • Install the new version
  • Make sure the existing functionality is not broken (default consent is not enabled by default, needs to be marked true in the settings app)

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

Type of changes

✔️ Type of Change
_ Bug fix
✔️ New feature
_ Breaking change
_ Technical improvements

Notes

* Move uc.js loading to head.html to ensure loading after default consent
@bdudabeecoded bdudabeecoded requested a review from a team as a code owner November 8, 2024 18:13
@bdudabeecoded bdudabeecoded requested review from RodrigoTadeuF, gabpaladino and vsseixaso and removed request for a team November 8, 2024 18:13
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 8, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

@digital-forge-mn digital-forge-mn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants