Skip to content

feat(imgs): removing lazy loading from eager images in the first fold #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joaocore wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(imgs): removing lazy loading from eager images in the first fold #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ade0a91
feat(imgs): removing lazy loading from eager images in the first fold
joaocore Apr 11, 2024
07f9823
fix: changed const name
joaocore May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion react/components/LazyImages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,17 @@ const useLazyImagesContext = () => {
interface MaybeLazyImageProps {
createElement: typeof React.createElement
imageProps: Record<string, any>
loadingType: string
}

const MaybeLazyImage: FC<MaybeLazyImageProps> = ({
createElement = React.createElement,
imageProps,
loadingType,
}) => {
const { lazyLoad, method } = useLazyImagesContext()

if (lazyLoad) {
if (lazyLoad && loadingType !== 'eager') {
let newImageProps = imageProps

switch (method) {
Expand Down
1 change: 1 addition & 0 deletions react/core/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ function start() {
{
createElement: ReactCreateElement,
imageProps: props,
loadingType: props.loading,
},
])
}
Expand Down