-
Notifications
You must be signed in to change notification settings - Fork 18
feature/ add a validation when render items in ItemLIst and items.len… #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/ add a validation when render items in ItemLIst and items.len… #206
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
HI @gabriel291-silva , thanks for the contribution, could you describe more how this fix is going to help/address an a11y issue and describe how to test it, please? A few more metrics with the after and before would be great. Another important point is that the changelog is missing |
Detailed description of how the fix resolves an accessibility (a11y) issue.During automated testing, it was detected that the component displayed a list structure; however, this structure did not contain any child items, making it invalid for the tests. To address this, I simply validated the existence of values so that this component containing the list would only be displayed when the list was not empty. Conclusion: The Instructions on How to Test the FixI will provide the workspace link. To test it, search for the class "itemListTitle" using DevTools in the links I will send. I will attach two links: One where the empty component is hidden. Link with the filled component displayed: Atualização do ChangelogAdded
|
|
@gabriel291-silva You can add the comment content in the PR definition to organize and request. |
|
Changed |
|
i adjusted the coment on changelog.md |
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |


…bility applications and automated testing
What is the purpose of this pull request?
I inserted a definition in the component, this modification is for accessibility app
What problem is this solving?
acessibility problems
Descrição detalhada de como a correção resolve um problema de acessibilidade (a11y).
durante os testes automatizados, foi captado que o componente exibia umas das estrutura de lista, porem essa estrutura não possuía nenhum tipo de item filho, e isso se tornou invalido para os testes, então apenas validei a existência dos valores para que esse componente que contem a lista fosse exibido somente quando a lista não fosse vazia, conclusão o componente “
” não será exibido vazio com essa validação de existência dos itens.
after :

Before

Instruções de como testar a correção.
irei disponibilizar o link do workspace, para testar buscar pela classe “itemListTitle” usando o devtools nos links eu irei lhe enviar, vou anexar dois links um onde o componente vazio e escondido e outro em que ele aparece com os conteúdos necessários para não ser um erro de acessibilidade.
link com o item vazio não exibido : https://vtexpr206--hmartus.myvtex.com/mango ice cream?_q=mango ice cream&map=ft&updateRegionalization=false&__bindingAddress=www.hmart.com/
link com o componente preenchido exibido : https://vtexpr206--hmartus.myvtex.com/rice---grain?__bindingAddress=www.hmart.com/&page=3
Atualização do changelog com as alterações feitas.
Added