Skip to content

Conversation

@thiagopereira-vtex
Copy link
Contributor

This pull request introduces the new data-af-element attribute to support ActivityFlow event tracking, updates the package manager metadata, and refines the Autocomplete UI components to improve semantic markup and event tracking. The most significant changes are grouped below by theme.

ActivityFlow event tracking enhancements:

  • Added the data-af-element attribute to all elements with ActivityFlow event triggers, including product tiles in TileList.tsx, facilitating more granular analytics and event tracking. [1] [2] [3]

Package management:

  • Updated package.json to specify the package manager as yarn@1.22.22 with a SHA-512 hash for improved reproducibility and security.

Autocomplete UI improvements:

  • Improved semantic markup and code readability in ItemList.tsx by wrapping icon and label elements in clearer spans and adjusting formatting. [1] [2]
  • Minor code and formatting cleanups in Autocomplete/index.tsx, including consistent default values and spacing. [1] [2] [3]
  • Ensured trailing commas for object literals in biggy-client.ts for style consistency.

These changes collectively improve event tracking capabilities, maintain package management best practices, and enhance code clarity in the Autocomplete component.

@thiagopereira-vtex thiagopereira-vtex requested a review from a team as a code owner October 9, 2025 18:49
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 9, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 9, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

@ArthurFerrao ArthurFerrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@thiagopereira-vtex thiagopereira-vtex merged commit 5981c08 into master Oct 9, 2025
9 of 10 checks passed
@thiagopereira-vtex thiagopereira-vtex deleted the feat/tis-369-af-attr branch October 9, 2025 19:30
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 9, 2025

Your PR has been merged! App is being published. 🚀
Version 2.18.6 → 2.18.7

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.search@2.18.7

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants