-
Notifications
You must be signed in to change notification settings - Fork 46
Added custom end point #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
| @@ -0,0 +1,5 @@ | |||
| export const VTEX_APP_KEY = process.env.VTEX_APP_KEY || 'vtexappkey-trika-ZYFCMI' | |||
| export const VTEX_APP_TOKEN = process.env.VTEX_APP_TOKEN || | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way is wrong. We need to add config into app the then use it.
amonap-trika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major comments, So, time being approving it.
| status: method({ | ||
| GET: [validate, status], | ||
|
|
||
| dataEntities: method({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data entities is very generic name, Its should more appropriate, Like contact, etc
| "@types/zen-observable@^0.8.0": | ||
| version "0.8.3" | ||
| resolved "https://registry.yarnpkg.com/@types/zen-observable/-/zen-observable-0.8.3.tgz#781d360c282436494b32fe7d9f7f8e64b3118aa3" | ||
| integrity sha512-fbF6oTd4sGGy0xjHPKAt+eS2CrxJ3+6gQ3FGcBoIJR2TLAyCkCyI8JqZNy+FeON0AhVgNJoUumVoZQjBFUqHkw== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file need to be ignored from getting pushed
Use this endpoint in postman
https://lokeshtri217--trika.myvtex.com/_v/dataEntities?start=0&end=6