Configurable thumbnail dimensions in product gallery #1120
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
vmourac-vtex
left a comment
vmourac-vtex
left a comment
There was a problem hiding this comment.
Add documentation to the corresponding component in docs folder
| thumbCustomWidth={thumbCustomWidth} | ||
| thumbCustomHeight={thumbCustomHeight} |
There was a problem hiding this comment.
Please add documentation for the new props in docs/ProductImages.md
There was a problem hiding this comment.
Also, please update your source branch to avoid merge conflicts with CHANGELOG.md
There was a problem hiding this comment.
Hi @vmourac-vtex, i have update docs for ProductImages.md. Can u check please ?
CHANGELOG.md in now fixed
|
@gabridevs the workspace provided in the PR is not working. |
Hi @vmourac-vtex, the worksoace is now working again. Check please |
|
hi @vmourac-vtex , i opened a new PR for this scenario and i create a separate branch for pr: |
2 participants
What problem is this solving?
This PR adds the ability to configure the width and height of product thumbnails in the carousel component. By allowing control over the thumbnail dimensions, this can improve page performance and SEO by ensuring that appropriately sized images are used, reducing unnecessary data loading.
How to test it?
You can test this feature by setting custom values for thumbCustomWidth and thumbCustomHeight in the product image gallery component. Ensure that thumbnails are resized correctly based on these values, and monitor the impact on page load times and SEO scores.
For test use this Workspace
Screenshots or example usage:
In production:
Official component in production unable to set thumbnail size.
See props: Product Image
In workspace:
can be able to set values in px from props component:
Describe alternatives you've considered, if any.
An alternative approach considered was to use CSS only for thumbnail resizing, but this would not allow for dynamic configuration through props or tailored image dimensions for performance.
Related to / Depends on
No dependencies.