Update gtin value #88

albertm805 · 2025-07-30T07:30:40Z

What problem is this solving?
Removes formatting from skuId if the value from the admin is itemId

How should this be manually tested?
This can be tested here

Screenshots or example usage:

vtex-io-ci-cd · 2025-07-30T07:30:43Z

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

Patch (backwards-compatible bug fixes)
Minor (backwards-compatible functionality)
Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

No thanks, I would rather do it manually 😞

vtex-io-docs-bot · 2025-07-30T07:30:53Z

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

There's nothing new to document 🤔
I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

I just updated 🎉🎉

react/Product.js

Copilot

Pull Request Overview

This PR fixes GTIN value handling by conditionally skipping formatting when the gtinValue configuration is set to 'itemId'. The change prevents unnecessary padding of item IDs that should remain in their original format.

Adds conditional logic to skip GTIN formatting for itemId values
Updates changelog to document the fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
react/Product.js	Implements conditional GTIN formatting logic based on gtinValue type
CHANGELOG.md	Documents the fix for GTIN formatting when value is itemId

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-24T19:02:35Z

react/Product.js

+  const gtin =
+    rawGTIN != null
+      ? gtinValue === 'itemId'
+        ? rawGTIN // don't format itemId
+        : formatGTIN(rawGTIN)
+      : null


[nitpick] The nested ternary operator creates complex logic that's hard to read. Consider refactoring to use an if-else structure or extracting the logic into a helper function for better maintainability.

Suggested change

const gtin =

rawGTIN != null

? gtinValue === 'itemId'

? rawGTIN // don't format itemId

: formatGTIN(rawGTIN)

: null

let gtin;

if (rawGTIN != null) {

if (gtinValue === 'itemId') {

gtin = rawGTIN; // don't format itemId

} else {

gtin = formatGTIN(rawGTIN);

}

} else {

gtin = null;

}

@copilot can you simplify the nested if-else statements? for instance, by initializing the gtin value with null?

iago1501

Hi @albertm805 , first of all, thanks for the PR

Just did the tech code review

After reviewing the code, I have one question: Why do we need to store the GTIN in an unformatted state? Given that GTINs are strictly 8, 12, 13, or 14 characters long, wouldn't padding with zeros be enough? The example you provided shows a 5-character number - can you help me understand the reasoning behind this approach?

react/Product.js

albertm805 · 2025-09-30T16:08:35Z

Hi @albertm805 , first of all, thanks for the PR

Just did the tech code review

After reviewing the code, I have one question: Why do we need to store the GTIN in an unformatted state? Given that GTINs are strictly 8, 12, 13, or 14 characters long, wouldn't padding with zeros be enough? The example you provided shows a 5-character number - can you help me understand the reasoning behind this approach?

The reason why I am storing the GTIN in a raw state is because it can be any length value. If you consider that it shouldn't be done it can be changed.

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-30T16:16:12Z

react/Product.js

+
+  let gtin = null
+
+  if (rawGTIN != null) {


Use strict equality (!==) instead of loose equality (!=) for null comparison to follow JavaScript best practices and avoid type coercion issues.

Suggested change

if (rawGTIN != null) {

if (rawGTIN !== null && rawGTIN !== undefined) {

@iago1501 is this something also an enhancement that will go with the PR or is there some other alternative code that you would like for me to include?

This is an antomatic review made by copilot, it's suggesting an enhancement in your code, it's related to best practices in js:

Use strict equality (!==) instead of loose equality (!=) for null comparison to follow JavaScript best practices and avoid type coercion issues.

It would be great if you could commit this suggestion in the PR since you are using explicit null comparison

iago1501 · 2025-10-13T13:38:42Z

Hi @albertm805 , regarding the GTIN value,

The reason why I am storing the GTIN in a raw state is because it can be any length value. If you consider that it shouldn't be done it can be changed.

Regarding the GTIN value, I understand that it can technically have any length, but perhaps it would be a good idea to follow what’s recommended in the documentation. If it specifies that GTIN should contain only 8, 12, 13, or 14 characters, I think it might be best to stick to those standards, even if that means adding leading zeros where necessary.

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

react/Product.js

CHANGELOG.md

iago1501

Just some semantical fixes

react/Product.js

vtex-io-ci-cd · 2025-12-08T16:12:29Z

Your PR has been merged! App is being published. 🚀
Version 0.16.0 → 0.16.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.structured-data@0.16.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

albertm805 requested a review from a team as a code owner July 30, 2025 07:30

albertm805 requested review from leo-prange-vtex, vmourac-vtex and vsseixaso and removed request for a team July 30, 2025 07:30

vsseixaso requested changes Sep 3, 2025

View reviewed changes

react/Product.js Outdated Show resolved Hide resolved

react/Product.js Outdated Show resolved Hide resolved

albertm805 requested a review from vsseixaso September 10, 2025 02:41

vmourac-vtex requested a review from Copilot September 24, 2025 19:02

Copilot AI reviewed Sep 24, 2025

View reviewed changes

iago1501 requested changes Sep 24, 2025

View reviewed changes

react/Product.js Outdated Show resolved Hide resolved

albertm805 requested review from Copilot and iago1501 September 30, 2025 16:15

Copilot AI reviewed Sep 30, 2025

View reviewed changes

albertm805 added 9 commits November 11, 2025 08:23

Update gtin value

d04ed6b

Update changelog

e86a81e

Update gtin value

aa28a2b

Fix linters

a5841be

Update code based on GH suggestion

ae510ae

Address linters from GH copilot

adba013

Update product schema render

aa68f01

Fix tests

5e19e73

Update fix for gtin value

9fb1b8c

albertm805 force-pushed the fix/gtin-value-parsed branch from 552dfe1 to 9fb1b8c Compare November 12, 2025 02:17

albertm805 requested a review from Copilot November 12, 2025 21:20

Copilot started reviewing on behalf of albertm805 November 12, 2025 21:21 View session

Copilot finished reviewing on behalf of albertm805 November 12, 2025 21:22

Copilot AI reviewed Nov 12, 2025

View reviewed changes

react/Product.js Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

albertm805 added 2 commits November 12, 2025 17:01

Remove duplicated line

9da1e72

Fix linter for changelog

8db46f7

iago1501 requested changes Dec 1, 2025

View reviewed changes

react/Product.js Outdated Show resolved Hide resolved

react/Product.js Outdated Show resolved Hide resolved

react/Product.js Outdated Show resolved Hide resolved

react/Product.js Outdated Show resolved Hide resolved

Update variable names

51c8f7b

albertm805 requested a review from iago1501 December 3, 2025 06:19

iago1501 approved these changes Dec 3, 2025

View reviewed changes

vmourac-vtex merged commit 81d3fdd into vtex-apps:master Dec 8, 2025
4 checks passed

-  const gtin =
-    rawGTIN != null
-      ? gtinValue === 'itemId'
-        ? rawGTIN // don't format itemId
-        : formatGTIN(rawGTIN)
-      : null
+  let gtin;
+  if (rawGTIN != null) {
+    if (gtinValue === 'itemId') {
+      gtin = rawGTIN; // don't format itemId
+    } else {
+      gtin = formatGTIN(rawGTIN);
+    }
+  } else {
+    gtin = null;
+  }

	if (rawGTIN != null) {
	if (rawGTIN !== null && rawGTIN !== undefined) {

Update gtin value #88

Update gtin value #88

Uh oh!

Conversation

albertm805 commented Jul 30, 2025

Uh oh!

vtex-io-ci-cd bot commented Jul 30, 2025 • edited by iago1501 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vtex-io-docs-bot bot commented Jul 30, 2025 • edited by iago1501 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

vmourac-vtex Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

iago1501 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

albertm805 commented Sep 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

albertm805 Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

iago1501 Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

iago1501 commented Oct 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

iago1501 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vtex-io-ci-cd bot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vtex-io-ci-cd bot commented Jul 30, 2025 •

edited by iago1501

Loading

vtex-io-docs-bot bot commented Jul 30, 2025 •

edited by iago1501

Loading

iago1501 left a comment •

edited

Loading