Skip to content

Fix/price on low price #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugo-expe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/price on low price #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c07f89b
Fix: compare same Price variables between range high/low
hugo-expe Jan 9, 2026
4f064c6
Changelog
hugo-expe Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Fixed
- Using tha same Price varaible to compare High and Low price to Fix escenarios when sportPrice is not available

## [0.16.1] - 2025-12-08

### Fixed
Expand Down
3 changes: 1 addition & 2 deletions react/Product.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { jsonLdScriptProps } from 'react-schemaorg'
import useAppSettings from './hooks/useAppSettings'
import { getBaseUrl } from './modules/baseUrl'

const getSpotPrice = path(['commertialOffer', 'spotPrice'])
const getPrice = path(['commertialOffer', 'Price'])
const getTax = path(['commertialOffer', 'Tax'])
const getAvailableQuantity = pathOr(0, ['commertialOffer', 'AvailableQuantity'])
Expand Down Expand Up @@ -167,7 +166,7 @@ const composeAggregateOffer = (

const aggregateOffer = {
'@type': 'AggregateOffer',
lowPrice: getFinalPrice(low, getSpotPrice, { decimals, pricesWithTax }),
lowPrice: getFinalPrice(low, getPrice, { decimals, pricesWithTax }),
highPrice: getFinalPrice(high, getPrice, { decimals, pricesWithTax }),
priceCurrency: currency,
offers: offersList,
Expand Down