Fixes crashes when we modify dependencies in ewpi packages #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crash happens because the _ew_package_index is not filled for dependencies not found in the current compilation, but array is iterated over all indices anyway, instead of just the dependencies dst count. The array returns garbage which is then dereferenced in _ewpi_pkgs and crashes. This patch makes this iterate over just the dependencies instead, and as such doesn't iterate over uninitialized array elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash happens because the _ew_package_index is not filled for
dependencies not found in the current compilation, but array is
iterated over all indices anyway, instead of just the dependencies dst
count.
The array returns garbage which is then dereferenced in _ewpi_pkgs and
crashes.
This patch makes this iterate over just the dependencies instead, and as
such doesn't iterate over uninitialized array elements.