Skip to content

Conversation

@couthcommander
Copy link
Contributor

@couthcommander couthcommander commented Jan 12, 2026

Fixes several small issues preventing DAG assignment within importUsers.

#500

This would replace pull request #499

Copy link
Member

@spgarbet spgarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the user of logWarning directly. News is in recommended format.

However, I'm seeing errors I think might related to database state.

✖ | 2 30 | 101-userMethods-Functionality [58.5s]
──────────────────────────────────────────────────────────────────
Failure (test-101-userMethods-Functionality.R:23:5): Import / Export Users
Users1 not equal to Users2.
Component “forms”: 3 string mismatches
Component “forms_export”: 3 string mismatches

Failure (test-101-userMethods-Functionality.R:147:5): Import User DAG Assignments
importUsers(rcon, data = Users) did not produce any warnings.
──────────────────────────────────────────────────────────────────
✔ | 20 | 102-userRoleMethods-ArgumentValidation
✔ | 13 | 102-userRoleMethods-Functionality [14.4s]

Copy link
Member

@spgarbet spgarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. The flush_dag_assignment() calls seem to be the secret sauce.

[ FAIL 0 | WARN 0 | SKIP 13 | PASS 2062 ]

@spgarbet spgarbet merged commit 5454f20 into main Jan 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants