Conversation
Two bugs fixed:
1. run-services.sh: Changed SERVER_TASKQUEUENAME to TASK_QUEUE_NAME
- DCA server config uses envconfig with TASK_QUEUE_NAME
- Wrong env var caused tasks to enqueue to default_queue
- DCA worker never received reshare tasks, causing keyshares
to be stored in wrong MinIO bucket (vultisig-verifier instead
of vultisig-dca)
2. policy_generate.go: Use public /plugins endpoint for billing
- Previous code used /plugin/{id} which requires auth
- Auth failure caused empty billing array
- Empty billing caused "billing policies count (0) does not
match plugin pricing count (2)" error on policy creation
- Now fetches from public /plugins endpoint and filters by ID
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changes that enabled successful E2E swap test: 1. Production overlay updates: - app-recurring/server v1.0.84 (has TaskQueueName fix) - vcli v1.0.3 (has billing fetch fix) - nodeSelector removal patches for infra StatefulSets 2. policy_generate.go billing fix: - Added missing 'frequency' field to billing entries - Handle nil frequency pointer correctly 3. DCA server.yaml: - Added SERVER_TASK_QUEUE_NAME env var for explicit config 4. Dockerfile improvements: - Include shared libraries for proper binary execution The upstream app-recurring fix (PR #142) added: cfg.Server.TaskQueueName = cfg.TaskQueueName This ensures DCA server routes reshare tasks to dca_plugin_queue, allowing DCA worker to participate in 4-party TSS reshare. E2E Test Result: - Plugin install: 4 parties, 6.2s, keyshares in both MinIO buckets - Swap: USDC→BTC signed and broadcasted successfully - TxHash: 0xbd2fd6264045989c2b50059b8ca832a2582fb95972e0099dfe80ad24603c3661 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.