feat: snapshot macro for test program #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vu Vo <vu.voth@gmail.com>
NTTVy03
reviewed
Feb 3, 2025
crates/syntax/src/snapshots/syntax__syntax__grammar_tests__block_happy_test_statements.snap
Show resolved
Hide resolved
crates/syntax/src/snapshots/syntax__syntax__grammar_tests__template_happy_test_statements.snap
Show resolved
Hide resolved
NTTVy03
approved these changes
Feb 3, 2025
NTTVy03
added a commit
that referenced
this pull request
Feb 3, 2025
NTTVy03
added a commit
that referenced
this pull request
Feb 3, 2025
NTTVy03
added a commit
that referenced
this pull request
Feb 3, 2025
NTTVy03
added a commit
that referenced
this pull request
Feb 3, 2025
vuvoth
pushed a commit
that referenced
this pull request
Feb 6, 2025
* skip trivial first tokens in parsing * remove comment in input test * manage out-of-bound case, update input test * update input test * update input test * make test programs private * remove comments in syntax tests * format * make Pragma optional, remove ROOT * rename close() params, use advance() in eat(), fix typo scope * parse params using list_identity * return Option in token_value() and position_of() * do not allow <--, <== in var declaration * make public signal optional in main component * fix format before merge * remove empty test * replace expect by eat in block * add scope parsing test * fix space in scope parsing test * update snapshot test for syntax * refactor syntax test * update input tests with snapshot * change param type in find signal into str * add snapshot guild * add some combine arithmetic operators * error report in expect and expect_any * update snapshot for combine operators * update snapshot test * fix wrap trivial tokens before open a tree * update template happy test * add operators into token kinds * add operators test * re-priority token kinds * fix clippy check * fix clippy check * rebase add-token-kinds * fix clippy check * fix clippy * remove duplicate declaration in grammar tests * add missing signal assign tokens * fix grammar of for statement * add statements test * fix declaration, support matrix * fix format * refactor declaration * use list identity parser in tuple * fix right curly count in block * extract function params * add declaration test * remove duplicate else in comment * replace eat by expect for curly in block * comment statement in declaration test * fix format * merge master after PR #68 * add snapshot for goto_definition test * allow \r in EndLine token * add ExpressionAtom token * group identifer in var, signal, component declaration * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Use Insta for test circom syntax parse. Flow: