T8105: Modify workflows failed due to pullrequest_target change#107
Closed
asklymenko wants to merge 1 commit intovyos:currentfrom
Closed
T8105: Modify workflows failed due to pullrequest_target change#107asklymenko wants to merge 1 commit intovyos:currentfrom
asklymenko wants to merge 1 commit intovyos:currentfrom
Conversation
Add new file package-smoketest.yml, this file is moved from vyos-1x, it will be used as a reusable workflow.
12 tasks
c-po
requested changes
Dec 20, 2025
| BUILD_BY: autobuild@vyos.net | ||
| DEBIAN_MIRROR: http://deb.debian.org/debian/ | ||
| DEBIAN_SECURITY_MIRROR: http://deb.debian.org/debian-security | ||
| VYOS_MIRROR: https://packages.vyos.net/repositories/current/ |
Member
There was a problem hiding this comment.
This is hardcoded to current
The package smoketest workflow is ONLY required in vyos-1x repo - is it really necessary to make it an overcomplicated re-usable workflow?
Contributor
Author
|
I am closing this PR, this issue will be resolved by another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
The pull_request_target workflows are now evaluated against the base repository’s default branch for branch protections and environment rules, not the pull request’s target branch.
It is required to change the structure to have only 1 common file for all branches. This workflow should call a branch-specific workflow to run tests.
New file package-smoketest.yml will be added, this file is moved from vyos-1x, it will be used as a reusable workflow.
Types of changes
Related Task(s)
Related PR(s)
Proposed changes
How to test
Checklist: