T7899: virtual-ethernet interfaces support broadcasts#44
Merged
Conversation
Compatibility levels before 10 are deprecated
The Linux Kernel treats virtual-ethernet interfaces like regular ethernet
interfaces. As ethernet interfaces support broadcasts and we have a completion
helper for broadcast interfaces, this must be extended for virtual-ethernet
interfaces.
vyos@vyos# ${vyos_completion_dir}/list_interfaces --broadcast
eth0 eth0.10 eth0.201 eth1 eth2 eth3 veth101 veth102 veth201 veth202
sever-sever
approved these changes
Oct 7, 2025
Member
sever-sever
left a comment
sever-sever
left a comment
There was a problem hiding this comment.
Add veth interfaces to the list broadcast interfaces
dmbaturin
approved these changes
Oct 9, 2025
Member
dmbaturin
left a comment
dmbaturin
left a comment
There was a problem hiding this comment.
They are certainly broadcast interfaces and we have a CLI for them, so I can't see any possible objections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
The Linux Kernel treats virtual-ethernet interfaces like regular ethernet interfaces. As ethernet interfaces support broadcasts and we have a completion helper for broadcast interfaces, this must be extended for virtual-ethernet interfaces.
Types of changes
Related Task(s)
Related PR(s)
Checklist: