Skip to content

vyos-op-run: T8306: improve debug logging and error reporting#50

Merged
sever-sever merged 3 commits intovyos:currentfrom
dmbaturin:T8306-vyos-op-run-debug-logging
Feb 25, 2026
Merged

vyos-op-run: T8306: improve debug logging and error reporting#50
sever-sever merged 3 commits intovyos:currentfrom
dmbaturin:T8306-vyos-op-run-debug-logging

Conversation

@dmbaturin
Copy link
Member

Change summary

Since vyos-op-run is a native executable, it's impossible to edit it in-place to add debug messages, so it's probably a good idea to add as much built-in debug logging as possible.

(Since log formatting functions are stored in thunks, they have no performance impact when debug is not enabled)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): internal change.

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link
Contributor

@jestabro jestabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend debug messages and error reporting; sanity check build and run was performed.

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend vyos-op-run for debugging/logging

@sever-sever sever-sever merged commit 1a600be into vyos:current Feb 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants