Edit Privacy and Considerations sections by clehner · Pull Request #37 · w3c/did-imp-guide

clehner · 2021-11-30T01:50:05Z

Continue editing from #20 and #26, applying minor changes in sections 5 and 6.

Improve case (capitalization) consistency
Fix typos
Reduce use of normative-sounding language
Attempt to improve some wording

Preview | Diff

msporny

Minor nits, otherwise LGTM.

msporny · 2021-11-30T16:13:29Z

index.html

-        permit tracing of a user in manner not understood or authorized by the
-        user
-        by some third party.
+        would permit tracing of a user by a third party


Suggested change

would permit tracing of a user by a third party

would enable tracking of a user, without consent, by a third party

Change committed in 26b848b

Discussing further in #37 (comment)

msporny · 2021-11-30T16:15:35Z

index.html

+        DID method implementations are encouraged to rotate keys and
+        identifiers as often as possible,
+        to avoid correlation.


I know that this was already in the implementer guide, but it makes no sense. If you have a DID that is static, it makes no sense to rotate keys often in order to avoid correlation.

Also, "rotating keys" generally does not avoid correlation. Using different identifiers for different contexts does, however.

Agree, key rotation is about mitigating compromise... not mitigating correlation....

But the part about identifiers is correct, generating a new short lived DID and using it for 1 purpose, and then rotating away from it without a network observing seeing that rotation does mitigate correlation.

did key comes to mind in this regard, I think this section can be improved.... very good catch and comments.

Changed: #37 (comment)

TallTed

Mostly minor language massage.

TallTed · 2021-11-30T16:34:59Z

index.html

@@ -1162,7 +1162,7 @@ <h2>Privacy Considerations</h2>

    <p>
      Decentralized Identifiers, like any other technology, can be used to


Suggested change

Decentralized Identifiers, like any other technology, can be used to

Decentralized Identifiers, like many other technologies, can be used to

Committed: 5c7153e

TallTed · 2021-11-30T16:36:27Z

index.html

+        DID method specifications are encouraged to have a section dedicated to
+        personal data, covering the extent to


Suggested change

DID method specifications are encouraged to have a section dedicated to

personal data, covering the extent to

DID method specifiers are encouraged to include a specification section

dedicated to personal data, covering the extent to

I think they are actually required to do this, by DID Core.... Privacy and Security considerations are requirements of a did method spec... maybe we can say some thing like "try and make these really impressive"... but still some folks will probably think they didn't go far enough.

Committed suggested change in b5dc795.

I don't see "personal data" mentioned in these requirements:

https://www.w3.org/TR/did-core/#security-requirements "requirements for all DID method specifications when authoring the Security Considerations section"

https://www.w3.org/TR/did-core/#privacy-requirements "requirements for all DID method specifications when authoring the Privacy Considerations section"

But it is discussed in non-normative sections:

https://www.w3.org/TR/did-core/#binding-to-physical-identity "A DID and DID document do not inherently carry any personal data and it is strongly advised that non-public entities do not publish personal data in DID documents."

https://www.w3.org/TR/did-core/#encrypted-data-in-did-documents "placing encrypted data in a DID document is not an appropriate means to protect personal data."

https://www.w3.org/TR/did-core/#keep-personal-data-private "If a DID method specification is written for a public-facing verifiable data registry where corresponding DIDs and DID documents might be made publicly available, it is critical that those DID documents contain no personal data." ...

We could say that the personal data section is encouraged in addition to the Privacy and Security considerations sections which are required. Or would personal data be a subsection of Privacy and/or Security considerations?

I agree that more encouragement to develop these sections would be good.

TallTed · 2021-11-30T16:40:08Z

index.html

+        would permit tracing of a user by a third party
+        in manner not understood or authorized by the user.


Suggested change

would permit tracing of a user by a third party

in manner not understood or authorized by the user.

would enable a third party to track a user without the user's authorization,

in a manner the user may not understand.

I applied the similar earlier change #37 (comment) (permit -> enable, tracing -> tracking, consent).
I like that this change uses the active voice.
But is it okay to not mention "authorized" here - i.e. that it is implied by "consent"?
Could use this change but change "consent" to "consent/authorization"?

[@clehner] Could use this change but change "consent" to "consent/authorization"?

Sure, s/consent/authorization/ applied above.

@TallTed
This change suggestion (diff) doesn't apply cleanly now, due to the changes in #37 (comment) (26b848b).
I see your newer change suggestion on this sentence as updated, here: #37 (comment).
The newer suggested phrasing is different from the one here.
Does the newer change suggestion supersede this one?

TallTed · 2021-11-30T16:45:03Z

index.html

        Review any applicable local law when considering developing or
-        operating a decentralized identifier method.
-      </p>
-
-      <p>Consider <a href="https://gdpr.eu/">GDPR</a>.</p>
-
-      <p>Consider <a href="https://oag.ca.gov/privacy/ccpa">CCPA</a>.</p>
-
-      <p>Consider <a
-          href="https://www.bis.doc.gov/index.php/policy-guidance/encryption">EAR</a>.
-      </p>
+        operating a decentralized identifier method. Consider the following:


Suggested change

Review any applicable local law when considering developing or

operating a decentralized identifier method.



Consider <a href="https://gdpr.eu/">GDPR</a>.

Consider <a href="https://oag.ca.gov/privacy/ccpa">CCPA</a>.

Consider <a

href="https://www.bis.doc.gov/index.php/policy-guidance/encryption">EAR</a>.



operating a decentralized identifier method. Consider the following:

Review any applicable local laws when considering developing or

operating a decentralized identifier method. Such local laws may

include, but are not limited to, the following:

Committed: 5f088c6

TallTed · 2021-11-30T16:46:33Z

index.html

+      Avoid technologies declared <em>de facto</em> standard based on
+      particular implementations but lacking open standards.


Suggested change

Avoid technologies declared de facto standard based on

particular implementations but lacking open standards.

Avoid technologies declared de facto standards based on

particular implementations but lacking open standard technical

specifications.

Committed: c9d2bc6

TallTed · 2021-11-30T16:50:11Z

index.html

+        methods cannot
+        store information other than a DID document, which reduces the direct
        interoperability, substitutability, and cost effectiveness of
        solutions that make use of rare or poorly supported features such as


Suggested change

solutions that make use of rare or poorly supported features such as

solutions that make use of rarely or poorly supported features such as

Committed: 287afe9

peacekeeper · 2021-12-01T07:13:46Z

Looks good, thanks for investing time in improving this.

OR13 · 2021-12-01T16:08:54Z

index.html


    <p class="advisement">
-      Support for legacy cryptography systems such as
+      Consider support for legacy cryptography systems such as


Suggested change

Consider support for legacy cryptography systems such as

Consider support for widely adopted cryptography systems such as

This might be controversial, but i think legacy has the wrong connotation here.

Suggested change

Consider support for legacy cryptography systems such as

Consider support for historically prevalent cryptography systems such as

?

Added both suggested phrasings, and removed the latter clause which I think is made redundant: c539bca

OR13

@clehner this PR is excellent, please apply or dismiss the suggested changes and ping me for a re-review.

brentzundel · 2021-12-01T16:42:54Z

index.html


    <section class="informative">
-      <h3>Zero Knowledge Proofs</h3>
+      <h3>Zero-Knowledge Proofs</h3>


this is not a comment on @clehner 's excellent editorial work.

Why does the DID Implementation Guide talk about zero-knowledge proofs at all? Perhaps to the extent that an issuer may wish to use a DID Document to publish the verification key for a zero-knowledge proof–capable VC, but beyond that, the information in this section seems to relate little to DIDs

DID documents are to contain such crypto material as may be necessary to communicate with the entity identified by that DID. DID method specifiers and implementers may use ZKPs for these purposes, which possibility I think makes this section just as relevant as any of the others here.

Really, my concern with the section is not that it talks about ZKPs and how they may be used with DIDs, my concern is that it doesn't.

The guidance here is to 1) use proper curves for ZKPs, 2) not use ZKP proof formats tied to specific ledger technology, and 3) not store schemas on ledgers.
What does this guidance have to do with DIDs?

@brentzundel -- This should perhaps become a new issue of its own?

brentzundel

I approve, once the suggestions already made by others have been accepted.

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

Co-authored-by: Orie Steele <orie@transmute.industries> Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

index.html

TallTed · 2021-12-04T01:16:20Z

index.html

+        identifiers as often as possible,
+        to avoid correlation.


Suggested change

identifiers as often as possible,

to avoid correlation.

identifiers as often as practical,

to avoid compromise and correlation, respectively.

Applied in 45d8529.

Related earlier discussion: #37 (comment)

OR13 · 2021-12-10T16:09:00Z

@TallTed would you mind resolving all change suggestions that have been addressed? or lmk if you feel this is good from your perspective?

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

TallTed · 2021-12-10T16:27:02Z

index.html

-        </a> should be consulted when selecting curves for usage with zero
-        knowledge proofs,
+          href="https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-pairing-friendly-curves">
+          Pairing-Friendly Curves</a>


Suggested change

Pairing-Friendly Curves</a>

Pairing-Friendly Curves</a>,

Committed: 5b85935

TallTed · 2021-12-10T16:29:43Z

[@OR13] @TallTed would you mind resolving all change suggestions that have been addressed? or lmk if you feel this is good from your perspective?

I have no "resolve" button anywhere. Another downside to applying suggestions externally to the thread where they're suggested, instead of using the "commit" button that's right there for the PR author (and possibly others).

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

clehner · 2022-03-01T19:31:34Z

I believe the requested changes have been resolved.

Edit Privacy and Considerations sections

2c38594

clehner marked this pull request as ready for review November 30, 2021 14:56

clehner requested review from OR13, mprorock and msporny as code owners November 30, 2021 14:56

msporny approved these changes Nov 30, 2021

View reviewed changes

TallTed suggested changes Nov 30, 2021

View reviewed changes

OR13 reviewed Dec 1, 2021

View reviewed changes

OR13 requested changes Dec 1, 2021

View reviewed changes

brentzundel reviewed Dec 1, 2021

View reviewed changes

brentzundel approved these changes Dec 1, 2021

View reviewed changes

clehner and others added 7 commits December 3, 2021 16:28

Improve wording about third-party tracking

26b848b

Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>

Adjust technology comparison regarding privacy

5c7153e

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

More consistency with standards and specifications

c9d2bc6

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

Improve reference to laws

5f088c6

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

Reduce use of metonymy

b5dc795

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

Attribute feature rarity to support

287afe9

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

Positively characterize prevalence

c539bca

Co-authored-by: Orie Steele <orie@transmute.industries> Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

TallTed reviewed Dec 4, 2021

View reviewed changes

index.html Outdated Show resolved Hide resolved

TallTed reviewed Dec 4, 2021

View reviewed changes

Adjust key/identifier rotation encouragement

45d8529

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

TallTed reviewed Dec 10, 2021

View reviewed changes

clehner and others added 2 commits December 10, 2021 11:35

Add comma after link

5b85935

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

Reword sentence about tracking

009bb6a

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

	would permit tracing of a user by a third party
	would enable tracking of a user, without consent, by a third party

		@@ -1162,7 +1162,7 @@ <h2>Privacy Considerations</h2>

		<p>
		Decentralized Identifiers, like any other technology, can be used to

	Decentralized Identifiers, like any other technology, can be used to
	Decentralized Identifiers, like many other technologies, can be used to

		DID method specifications are encouraged to have a section dedicated to
		personal data, covering the extent to

		would permit tracing of a user by a third party
		in manner not understood or authorized by the user.

		Avoid technologies declared <em>de facto</em> standard based on
		particular implementations but lacking open standards.

-      Avoid technologies declared <em>de facto</em> standard based on
-      particular implementations but lacking open standards.
+      Avoid technologies declared <em>de facto</em> standards based on
+      particular implementations but lacking open standard technical
+      specifications.

	solutions that make use of rare or poorly supported features such as
	solutions that make use of rarely or poorly supported features such as

	Consider support for legacy cryptography systems such as
	Consider support for widely adopted cryptography systems such as

	Consider support for legacy cryptography systems such as
	Consider support for historically prevalent cryptography systems such as

Conversation

clehner commented Nov 30, 2021 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msporny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TallTed left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TallTed Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peacekeeper commented Dec 1, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OR13 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brentzundel left a comment

Choose a reason for hiding this comment

Uh oh!

clehner commented Nov 30, 2021 •

edited by pr-preview bot

Loading

TallTed Nov 30, 2021 •

edited

Loading