Clarify proof property definition #250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip-abramson
requested review from
ChristopherA,
danpape,
dmitrizagidulin,
mccown and
peacekeeper
as code owners
peacekeeper
approved these changes
Dec 9, 2025
swcurran
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #235 per @peacekeeper's suggestion.
However, it does not address the final part of Jeffery's initial comment:
There is no definition of what proofs are supposed to hold, this is DID method specific I believe. Are there even any DID methods today that define how to use this property? Are we just reserving the proof field for DID methods to override how they like?
Preview | Diff