Skip to content

Make compile script retry if a 409 is encountered #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mltsy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make compile script retry if a 409 is encountered #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 32 additions & 13 deletions bin/compile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,28 @@ curl -sSf "${API}/releases/${SOURCE_VERSION}/files/" \
-H "Authorization: Bearer ${SENTRY_AUTH_TOKEN}" \
> "$files"

# Function to update a file in Sentry
update_file() {
local map=$1
local name=$2
local file_id=$3

echo " Updating ${map} on Sentry"
curl -sSf "${API}/releases/${SOURCE_VERSION}/files/${file_id}/" \
-X DELETE \
-H "Authorization: Bearer ${SENTRY_AUTH_TOKEN}" \
>/dev/null
curl -sSf "${API}/releases/${SOURCE_VERSION}/files/" \
-X POST \
-H "Authorization: Bearer ${SENTRY_AUTH_TOKEN}" \
-F file=@"${map}" \
-F name="${name}" \
>/dev/null || {
status=$?
echo " Failed to upload ${map}, status code: $status"
}
}

# Upload the sourcemaps
cd "${build}/"

Expand All @@ -65,21 +87,18 @@ for map in $(find . -name '*.js.map' -not -path './node_modules/*' -not -path '.
-H "Authorization: Bearer ${SENTRY_AUTH_TOKEN}" \
-F file=@"${map}" \
-F name="${name}" \
>/dev/null
>/dev/null || {
status=$?
if [ $status -eq 22 ]; then
echo " 409 Conflict for ${map}, performing update."
update_file "${map}" "${name}" "${res[0]}"
else
echo " Failed to upload ${map}, status code: $status"
Comment on lines +95 to +96
Copy link
Author

@mltsy mltsy May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is what we want here... maybe we want it to just fail?

fi
}

elif [[ "${res[1]}" != "${sum}" ]]; then
echo " Updating ${map} on Sentry"
curl -sSf "${API}/releases/${SOURCE_VERSION}/files/${res[0]}/" \
-X DELETE \
-H "Authorization: Bearer ${SENTRY_AUTH_TOKEN}" \
>/dev/null
curl -sSf "${API}/releases/${SOURCE_VERSION}/files/" \
-X POST \
-H "Authorization: Bearer ${SENTRY_AUTH_TOKEN}" \
-F file=@"${map}" \
-F name="${name}" \
>/dev/null

update_file "${map}" "${name}" "${res[0]}"
else
echo " ${map} is up-to-date"
fi
Expand Down