-
Notifications
You must be signed in to change notification settings - Fork 40
Fix false positive broken image reports in Lychee PR check #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change triggers a new deployment which will use the corrected link checker workflow. The previous run was using an older version from main that incorrectly checked against docs.wandb.ai instead of the preview URL.
Contributor
📚 Mintlify Preview Links🔄 Renamed/Moved (1 total)📄 Pages (1)
✨ Added (13 total)📄 Pages (7)
🖼️ Images (6)
📝 Changed (26 total)📄 Pages (23)
🖼️ Images (2)
⚙️ Other (1)
🗑️ Deleted (19 total)View deleted files🖼️ Images (19)
🤖 Generated automatically when Mintlify deployment succeeds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix false positive broken images as seen in #2011
PR check did not correctly detect the PR preview URL, leading to false positive 404s for all images added by the PR, across English, Japanese, and Korean
Testing
mint dev)mint broken-links)