Removed lines causing non-determinism #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non determinism in this test is caused by the object mapper class that is used by the mockserver class for testing. The object mapper is used to serialize a list http requests in one string and send them to a server. However, it does not print to the string in the same order everytime. For example, name, path, and body in one http request does not get printed in the same order when it is send to the mock client for expection and verification by
VerificationSequenceSerializer.serialize()andExpectationSerializer.serialize().This is not a fix as I only removed lines using object mapper and I don't know how to fix this as the serialization functions are part of standard library.