Support protobuf map type #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximus
commented
Dec 8, 2023
| end | ||
| end | ||
|
|
||
| def serialize(descriptor, value) |
stomk
requested review from
a team and
qnighy
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used maps in my app, and it failed.
Under the hood, maps are implemented as
repeatedmessages of two fieldskey,value. They are described as such in the descriptor tree, with the only particularity is that the "virtual" key/value message has an option calledmap_entryset.The current version of the_pb handles map types naively as those repeated messages. It converts
{ "foo" => "bar" }to[<MapEntry key="foo", value="bar">]. You would think this is correct, but the whenklass.new(params)is executed, protobuf throws an error. Protobufs actually wants a hash object for the map type. It handles theHashtoMapEntry[]conversion itself.This fixes it. I'm sure the code could be better, let me know if you want changes.
Without the code change, new test cases would fail.
This also updates gems in the same PR, sorry. It was necessary to run on ruby 3.2 which is what I have installed. Also there is little activity on this project so it should not bother, let me know.