Added move thumbs by touch + fix for stuck thumbs #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now touching slider moves the closest thumb to touch point. Also- fixed a bug- when two thumbs are at the extreme- trying to drag open the range doesn't work because the most extreme thumb gets the touch (instead of the inner thumb that needs to move). Also, dragging one thumb over the other opens the range in the opposite direction (the thumbs "flip sides" and continue to move).
|
Not that I have any say in this project really (but I do use it) - but the indentation you got going on in this patch is whack. Can't really see what's changing, looks like everything is. |
|
I agree with @scottcc, and another thing (please consider it constructive feedback! 😃 ): it's no point keeping code that you have commented away in your commit, in case anybody needs that code back, it always remain in the git history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now touching slider moves the closest thumb to touch point.
Also- fixed a bug- when two thumbs are at the extreme- trying to drag open the range doesn't work because the most extreme thumb gets the touch (instead of the inner thumb that needs to move). Also, dragging one thumb over the other opens the range in the opposite direction (the thumbs "flip sides" and continue to move).