Draft
Conversation
Creates a generator project that catches all references to generic names and generates warnings. This is the first step in catching references to the AddDefaultParser generic method and replacing them with calls to add explicitly constructed parsers that use either the TryParse or string constructors on the associated type. This avoids the need to use reflection and makes the code safer for trimming, as well as allowing us to raise an error if the type doesn't support a default parser.
Insomniak47
reviewed
Sep 25, 2023
| @@ -0,0 +1,5 @@ | |||
| using Geis; | |||
Member
There was a problem hiding this comment.
Not to be the old man "No, the kids are wrong" but I'd prefer not using top level statements
Insomniak47
reviewed
Sep 25, 2023
| { | ||
| public void Initialize(IncrementalGeneratorInitializationContext context) | ||
| { | ||
| //System.Diagnostics.Debugger.Launch(); |
Member
There was a problem hiding this comment.
Might be good to put this behind a flag and conditional compile it in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a generator project that catches all references to generic names and generates warnings. This is the first step in catching references to the AddDefaultParser generic method and replacing them with calls to add explicitly constructed parsers that use either the TryParse or string constructors on the associated type. This avoids the need to use reflection and makes the code safer for trimming, as well as allowing us to raise an error if the type doesn't support a default parser.