draft: need a pr to check things #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: details formatter throws on empty collection of checks * first shot (without addl tests) of the move to IAsyncEnumerable<T> Also added paging and a cli flag for count on show (that we can default when we get around to the peer config feature) * initial tests for detailsformatter * Make github PRs use lazy evaluation where possible by swapping to fully IAsyncEnumerable implementations * cleanup and formatting * whitespace and formatting * fix pagesize on query (should remove param) and fixed infinite loop when sorting * fix: nullability of check conclusion state * Cleanup of pull request, factored out ScalarExtensions. General cleanup * use page size again, add provider, author, title to sorts * fix tests that needed author * skip return of prs with 'has more comments' until end of the loop * spent a few more letters so ttd will eat with the group * formatting and usings * remove extra nullable annotation * accidentally removed linq using * Change EndCursor to after in pr query
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat: add sort keys to show help * replace extra : in sort direction description with | * chocky * id -lex typo
* chore: tests and validation for Check class * chore: add tests for emoji provider and stryker tool config
Admin override into main (Reviewers all busy) * feat: add initial filter impl * move to using regex filter instead of action filter * separating files and formatting * case insensitive regex * adding initial tests for filters * Add filter separator as ' ', remove debug statements, aggregate instead of for loop
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…139) * fix: accept filter contents with embedded colons (like 'title:fix:') * fix: raw literal instead of expression * chore: add additional tests for the filter parsing code
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…the way (#141) OVERRIDE - Hotfix + reviewers are all out sick
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…g author with 'octoghost' in those cases (#143)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: handle errors in show/watch Add exception handling to the show command to display the exception message instead of crashing (which would previously dump the stack trace) and return an error result. Update the watch command so that it will handle a few failed show commands before exiting gracefully. * use configurable retry in show and watch * dotnet format + remove unused usings * wrap all GQL requests in cancellation-terminated retry * remove unnecessary setters
…ements (and one in show) until we figure out how we want to approach it (#152) Overriding - reviewers are ghosts
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…roperly. Also flattened out some of the async enumerables (#156)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat: configurable show timeout Adds a configurable show timeout to the existing configuration format. There is already a TODO to reconsider the configuration shape so this is a quick/temporary solution until that thinking is done. Adds a specific error message for timeouts. * docs: update comments in config example * docs: mention timeout setting in error message * Update Peer.Domain/Commands/Config.cs Co-authored-by: Chris Nantau <Chris.Nantau@Hey.com> Co-authored-by: Chris Nantau <Chris.Nantau@Hey.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ttd2089
reviewed
Oct 8, 2022
| { | ||
| public interface IPropertySelector | ||
| { | ||
| Func<PullRequest, IComparable> Selector { get; } |
Member
There was a problem hiding this comment.
Could be declared as a normal method member? I think anything needing a Func<A, B> can accept a reference to x.Foo where x is an object with a member B Foo(A a).
Member
There was a problem hiding this comment.
I don't recall the usage so maybe this makes more sense semantically. It looked strange at first and got me thinking about whether there was a functional difference. I might not suggest the change but I'm curious about the equivalence now either way.
OVERRRIDE - Preapproved diffs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat: wrap all the comand stuff into a builder so we can reduce some of the complexity and do subcomands because they're unsupported * re-org * Swap to return codes for handlers for now * add some poistive tests on exit code for now * feat: rearrange a bit, separate parsing from running * pull out TextResults into their own files * fix configuration * Verbs must have either a handler or subs * formatting pass * move handlers into handler namespace * more local tests and remove public from setup handler * Add the file location to the config info * feat: config edit command (#167) * initial impl of the config edit verb I've included support for EDITOR with a fallback to the default OS provider * formatting pass * classes into their own files * add runtime config per command for registering handlers * pull ProviderLoader from VerbBuilder * cleanup parsing and handle more cases, remove some code from try
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Donec et odio pellentesque diam volutpat commodo sed. Risus in hendrerit gravida rutrum quisque non tellus orci ac. Nascetur ridiculus mus mauris vitae ultricies leo integer. Maecenas accumsan lacus vel facilisis volutpat. Egestas congue quisque egestas diam in arcu cursus. Dolor sit amet consectetur adipiscing elit pellentesque. Scelerisque eleifend donec pretium vulputate sapien. Volutpat est velit egestas dui id ornare. Lobortis elementum nibh tellus molestie nunc. Vestibulum morbi blandit cursus risus. Porttitor lacus luctus accumsan tortor posuere ac ut consequat semper.
Tellus elementum sagittis vitae et leo duis. Arcu odio ut sem nulla. Mattis nunc sed blandit libero volutpat sed cras ornare arcu. At risus viverra adipiscing at in. Rutrum tellus pellentesque eu tincidunt tortor aliquam nulla facilisi. Massa placerat duis ultricies lacus sed turpis. In fermentum et sollicitudin ac orci phasellus egestas tellus rutrum. Et magnis dis parturient montes nascetur ridiculus. Faucibus in ornare quam viverra orci sagittis eu volutpat odio. Tempor orci dapibus ultrices in iaculis. Risus nec feugiat in fermentum posuere urna nec tincidunt praesent. Volutpat diam ut venenatis tellus in. Lectus quam id leo in vitae turpis massa sed. Risus nec feugiat in fermentum. Ultricies lacus sed turpis tincidunt id aliquet risus. Mi bibendum neque egestas congue quisque egestas diam in arcu. Non quam lacus suspendisse faucibus interdum posuere lorem.
Amet massa vitae tortor condimentum lacinia quis vel. Eu ultrices vitae auctor eu. Tortor posuere ac ut consequat semper. Vel orci porta non pulvinar neque. Facilisis sed odio morbi quis commodo odio. Amet commodo nulla facilisi nullam vehicula ipsum a. Dolor sed viverra ipsum nunc aliquet bibendum. Aliquam eleifend mi in nulla posuere sollicitudin aliquam. Commodo nulla facilisi nullam vehicula ipsum a arcu cursus. Massa tempor nec feugiat nisl. Laoreet suspendisse interdum consectetur libero id. In aliquam sem fringilla ut morbi tincidunt augue interdum. Tincidunt dui ut ornare lectus sit amet est. Adipiscing bibendum est ultricies integer. Feugiat in fermentum posuere urna nec tincidunt praesent. Congue quisque egestas diam in arcu cursus. Arcu vitae elementum curabitur vitae nunc. Mi sit amet mauris commodo quis imperdiet massa tincidunt. Aliquam vestibulum morbi blandit cursus risus.
Nunc sed velit dignissim sodales ut eu sem. Mattis enim ut tellus elementum sagittis. Enim neque volutpat ac tincidunt. Iaculis at erat pellentesque adipiscing commodo elit at. Diam sit amet nisl suscipit adipiscing bibendum est ultricies. Turpis egestas pretium aenean pharetra. Euismod in pellentesque massa placerat. Egestas sed tempus urna et pharetra pharetra massa massa. Enim ut tellus elementum sagittis vitae et leo duis ut. Iaculis at erat pellentesque adipiscing commodo elit at imperdiet dui. Dignissim diam quis enim lobortis scelerisque fermentum dui faucibus in. Vulputate mi sit amet mauris commodo. Feugiat pretium nibh ipsum consequat nisl vel. Tortor posuere ac ut consequat semper viverra nam libero.
Eget magna fermentum iaculis eu non diam. Arcu bibendum at varius vel pharetra vel turpis nunc eget. Eleifend mi in nulla posuere. Sed viverra ipsum nunc aliquet bibendum. Tincidunt arcu non sodales neque sodales ut etiam sit amet. Malesuada pellentesque elit eget gravida cum sociis. Sed cras ornare arcu dui vivamus arcu. Ac felis donec et odio pellentesque diam volutpat. Nullam non nisi est sit amet facilisis. Integer malesuada nunc vel risus commodo. Odio facilisis mauris sit amet massa vitae tortor. Magna etiam tempor orci eu lobortis elementum nibh. Gravida in fermentum et sollicitudin ac. Sit amet consectetur adipiscing elit pellentesque habitant morbi. Egestas purus viverra accumsan in nisl nisi. Sed ullamcorper morbi tincidunt ornare massa eget egestas. Vulputate ut pharetra sit amet aliquam id diam.
Nulla pharetra diam sit amet nisl. Sed cras ornare arcu dui vivamus arcu felis bibendum ut. Nunc consequat interdum varius sit amet. Sem integer vitae justo eget magna fermentum iaculis eu. Facilisi etiam dignissim diam quis enim lobortis. Habitant morbi tristique senectus et netus et malesuada fames ac. Placerat duis ultricies lacus sed turpis tincidunt. Fermentum dui faucibus in ornare quam. Vulputate dignissim suspendisse in est ante in. Viverra nibh cras pulvinar mattis nunc sed blandit libero. Id leo in vitae turpis massa sed elementum tempus egestas. Massa tincidunt dui ut ornare. Phasellus vestibulum lorem sed risus ultricies tristique nulla aliquet. Ac turpis egestas sed tempus urna et pharetra pharetra. In nibh mauris cursus mattis molestie a. Odio eu feugiat pretium nibh ipsum consequat. Risus commodo viverra maecenas accumsan lacus vel facilisis volutpat. Placerat duis ultricies lacus sed turpis tincidunt id aliquet risus. Risus nec feugiat in fermentum posuere urna nec. Quis commodo odio aenean sed adipiscing diam donec adipiscing tristique.
Vestibulum sed arcu non odio. Id interdum velit laoreet id donec ultrices. Eget nulla facilisi etiam dignissim diam quis enim lobortis scelerisque. Commodo viverra maecenas accumsan lacus. Eget nunc scelerisque viverra mauris in aliquam sem fringilla ut. Adipiscing tristique risus nec feugiat in fermentum posuere urna nec. Cras semper auctor neque vitae tempus quam pellentesque nec nam. Sapien nec sagittis aliquam malesuada bibendum arcu vitae elementum curabitur. Bibendum neque egestas congue quisque egestas diam in arcu. Scelerisque varius morbi enim nunc faucibus a pellentesque. Felis donec et odio pellentesque. Orci nulla pellentesque dignissim enim sit amet venenatis. Ante metus dictum at tempor commodo ullamcorper.