Enhance data processing and utility functions #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `process_price_change` to accept an optional `asset_id` parameter for better asset validation. - Modified `process_data` to ensure `json_datas` is always a list and to pass `asset_id` when available. - Added checks in `update_markets` to ensure the 'multiplier' column exists and fill NaN values with empty strings. - Refactored multiplier application in `get_buy_sell_amount` to use `row.get()` for safer access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_price_changeto accept an optionalasset_idparameter for better asset validation.process_datato ensurejson_datasis always a list and to passasset_idwhen available.update_marketsto ensure the 'multiplier' column exists and fill NaN values with empty strings.get_buy_sell_amountto userow.get()for safer access.Fixes #20