test(workflow): add symlink loop detection tests for LoadWorkflowFile #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive tests to verify that LoadWorkflowFile properly handles
circular symlinks during YAML file loading:
- Self-referencing symlink (file.yml -> file.yml)
- Circular symlink chain (a.yml -> b.yml -> a.yml)
- Deep symlink chain (10-link circular chain)
- Symlink through directories with loop
- Relative symlink loop (./current.yml -> ./current.yml)
- Triple symlink loop (x.yml -> y.yml -> z.yml -> x.yml)
- Valid symlink to real file (positive test case)
These tests ensure the OS-level symlink loop detection ("too many levels
of symbolic links" error) is properly surfaced and that the function
does not hang when encountering circular references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests to verify that LoadWorkflowFile properly handles
circular symlinks during YAML file loading:
These tests ensure the OS-level symlink loop detection ("too many levels
of symbolic links" error) is properly surfaced and that the function
does not hang when encountering circular references.