Skip to content

Conversation

@ralfbosz
Copy link

The True in the repo.pp is case-sensitive, the true in the sssd.conf
may not be, but to make it equal to the rest changed it.

@ralfbosz ralfbosz changed the title Thist commit converts True to true This commit converts True to true Jun 12, 2017
The True in the repo.pp is case-sensitive, the true in the sssd.conf
may not be, but to make it equal to the rest changed it.
@waveclaw
Copy link
Owner

I am not surprised the checks for this change all faile.

I have not finished building out the test infrastructure for this module. It looks like the sssd.conf.erb file is invalid and needs work.

That template is part of adding client support - the module is already a rough interface to the IPA server RPC/JSON API - and not terribly functional, yet.

Do you have a passing testcase for this change?

@ralfbosz
Copy link
Author

No I haven't looked at the tests, I only checked if there was a check for "True" instead of "true".

Just found that when using Puppet 4 this module won't work unless "True" is "true", haven't had time to look into the testing part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants