fix(render): correct multi-lane field rendering #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields spanning multiple lanes duplicated bits and labels. Solution: Clip fields per lane, slice and shift attributes per lane and use lane bounds for edge labels to render accurately across lanes. This work was sponsored by OIP Sensor Systems Signed-off-by: Thomas Vreys <thomas.vreys999@gmail.com>
|
LGTM. I'm using the PR and it did fix the issue that not all fields of the register where at the correct place rendered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fields spanning multiple lanes duplicated bits and labels.
Solution
This ensures multi-lane fields render correctly with unique labels and no overlap.
Related Issues
Fixes #59