Skip to content

Conversation

Copy link

Copilot AI commented Dec 5, 2025

The REF_COLLOCATION_DATA_DEFINED macro created unnecessary coupling between collocation_common.hpp and hdf5_test_serialization_impl.hpp, enforcing include ordering via compile-time error.

Changes

  • Removed #define REF_COLLOCATION_DATA_DEFINED from tests/collocation_common.hpp
  • Removed #ifndef REF_COLLOCATION_DATA_DEFINED check from tests/hdf5_test_serialization_impl.hpp
  • Added direct include of collocation_common.hpp in tests/hdf5_test_serialization_impl.hpp to make it self-contained

Both files use #pragma once for include guards, which properly handles multiple inclusions. The macro was redundant and created fragile ordering dependencies. The header is now self-contained and doesn't require consumers to include dependencies in a specific order.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: wavefunction91 <6208701+wavefunction91@users.noreply.github.com>
Copy link
Author

Copilot AI commented Dec 5, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • gitlab.com
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update header guard based on pull request feedback Remove macro-based header guard in favor of pragma once Dec 5, 2025
Copilot AI requested a review from wavefunction91 December 5, 2025 22:38
…pl.hpp

Co-authored-by: wavefunction91 <6208701+wavefunction91@users.noreply.github.com>
@wavefunction91 wavefunction91 marked this pull request as ready for review December 8, 2025 19:25
@wavefunction91 wavefunction91 merged commit 14214cf into feature/no_cereal Dec 8, 2025
26 checks passed
@wavefunction91 wavefunction91 deleted the copilot/sub-pr-163 branch December 8, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants