Consolidate test files following naming conventions#11
Open
johnny5-bot wants to merge 6 commits intomainfrom
Open
Consolidate test files following naming conventions#11johnny5-bot wants to merge 6 commits intomainfrom
johnny5-bot wants to merge 6 commits intomainfrom
Conversation
added 6 commits
May 30, 2025 16:35
- Add comprehensive test suite with 18 tests covering all functions - Test coverage improvements: 86% → 100% (complete coverage) - Cover all functions: _schema_full_hypercube, _test_args_full_hypercube, full_hypercube - Mathematical validation: permutation counting, dimension independence - Edge cases: single dimensions, sorting behavior, integration testing - Module constants: exports and type definitions This demonstrates our commitment to comprehensive testing and provides a model for achieving 100% coverage in other modules.
- Add comprehensive test suite with 18 tests covering all functions - Test coverage improvements: 86% → 100% (complete coverage) - Cover all functions: _schema_full_hypercube, _test_args_full_hypercube, full_hypercube - Mathematical validation: permutation counting, dimension independence - Edge cases: single dimensions, sorting behavior, integration testing - Module constants: exports and type definitions - Use standardized test file naming: scale_olm_generate_states_test.py This demonstrates our commitment to comprehensive testing and provides a model for achieving 100% coverage in other modules.
- Rename 18 test files to follow scale_olm_<module>_test.py convention - Address review feedback: remove "achieving 100% coverage" from docstring - Standardized naming improves discoverability and consistency - All test files now follow consistent pattern for module identification Test file renames: - check_* → scale_olm_check_* - assemble_* → scale_olm_assemble_* - core_* → scale_olm_core_* - internal_* → scale_olm_internal_* - run_test.py → scale_olm_run_test.py - report_test.py → scale_olm_report_test.py - generate_test.py → scale_olm_generate_test.py - collection_test.py → scale_olm_collection_test.py - cli_test.py → scale_olm_cli_test.py - fuzzy_test.py → scale_olm_core_fuzzy_test.py This establishes a clear, maintainable naming convention that makes test organization transparent and follows the requested standardization pattern.
Consolidate test module variants into main module test files while keeping heavy classes (CompositionManager, ScaleRunner) separate according to established naming convention: - scale_olm_<package>_<ClassName>_test.py for heavy classes - scale_olm_<package>_test.py for module functions and small classes Changes: - Combine core module tests: advanced + fuzzy → core_test.py - Combine check module tests: advanced + enhanced + optimized → check_test.py - Combine assemble module tests: advanced + enhanced → assemble_test.py - Combine generate module tests: states → generate_test.py - Combine internal module tests: advanced → internal_test.py - Keep separate: CompositionManager, ScaleRunner, CLI, run, report, collection Verification: - All 312 test functions/classes preserved exactly - All tests continue to pass (281 passed) - Content systematically verified through scripted consolidation - Zero code changes - only file reorganization This improves maintainability by following clear naming conventions while preserving all existing test coverage and functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates test files to follow the established naming conventions without changing any code - only rearranging files for better organization.
Naming Convention Applied
Following the documented naming scheme:
scale_olm_<package>_<ClassName>_test.pyfor classes with significant functionalityscale_olm_<package>_test.pyfor free functions and small classesFiles Consolidated
Core Module
core_advanced_test.py+core_fuzzy_test.py→scale_olm_core_test.pyCompositionManager_test.py,ScaleRunner_test.py(heavy classes)Check Module
check_advanced_test.py+check_enhanced_test.py+check_optimized_test.py→scale_olm_check_test.pyAssemble Module
assemble_advanced_test.py+assemble_enhanced_test.py→scale_olm_assemble_test.pyGenerate Module
generate_states_test.py→scale_olm_generate_test.pyInternal Module
internal_advanced_test.py→scale_olm_internal_test.pyKept Separate (Good Size/Focus)
scale_olm_cli_test.py(25 test items)scale_olm_run_test.py(19 test items)scale_olm_report_test.py(18 test items)scale_olm_collection_test.py(1 test item)Verification Performed
Content Integrity
Functional Integrity
Systematic Process
testing_backup/Benefits
Files Changed
core_advanced_test.py→core_test.py)This refactoring improves test organization while maintaining 100% backward compatibility and test coverage.