Skip to content

Conversation

@agilgur5
Copy link

Summary

The directions previously did not link to it so it was unclear where it came from and confused users
Fixes #62

Details

Adds an in-line link to the apply-waydroid-patches function when it is referenced for clarity

- the directions previously did not link to it so it was unclear where it came from and confused users
@aleasto
Copy link
Member

aleasto commented Jan 12, 2025

apply-waydroid-patches is exposed to PATH after . build/envsetup.sh. It should not be downloaded.

@agilgur5
Copy link
Author

The link doesn't say to download it -- it just shows where it is. It's on $PATH, but how it got there and where it came from is unclear right now. I was similarly confused like the OP in the issue

Is there a different wording you'd prefer?

@guitcastro
Copy link

guitcastro commented Aug 13, 2025

Wouldn't be better to replace apply-waydroid-patches with:

vendor/extra/waydroid-patches/apply-patches.sh

?

@agilgur5
Copy link
Author

agilgur5 commented Aug 14, 2025

Agree, directly running the script would be more intuitive to me than running a function that was added to $PATH. It removes some layers of abstraction that cause confusion in this case, IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Help! Don't understand "apply-waydroid-patches"

3 participants