Handle case where remaining groups are empty#5
Open
bburgin wants to merge 1 commit intowchill:masterfrom
Open
Conversation
Owner
|
Seems like #2 also was an old attempt at addressing this issue, but instead of leaving empty groups it would distribute the work better so that there were no empty groups. Wouldn't that be a better approach? |
Author
|
This pull request is smaller and does not change the existing distribution behavior. I agree that the other pull request adds more value, but it changes more behavior. Also since the other pull request was not accepted, I figured I would attempt a simpler fix for the issue I was getting. |
|
Can this please be merged |
|
please merge it, without it it breaks testing |
|
Any chance that this PR gets merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to this issue mark-adams#17, but for the the pytest-split-tests module:
I want to avoid the "Invalid test-group argument" error for cases where the remaining group is empty, due to the item count and group_count yielding a group_size that does not evenly distribute across all the groups of the group_count. Example:
item count = 2001
group_count = 200
group_size is then 11
and the last 18 groups are empty
When iterating over the 18 empty groups, I don't want the pytest-split-tests plugin to fail out.
I want it to instead just run no tests for these groups.