Containerising Outpost rails v6 #281
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so, I made a bit of a mess with all this - but this should be the one we want! 😂
Initially I merged in the rails 7 work as part of the containerisation since we'd be testing extensively as part of the release. I also thought it would help solve the webpacker issue. I've since realised it doesn't actually solve that issue and may cause the oauth functionality to break so I created a new version of the container without the rails 7 commits to be on the safe side.
Which would make the commit cleaner except...
I'm trying out tower to manage all my 1000 repos, but for some reason it had
HEADset as develop (even though it totally didn't!) so when I went to push to my nice feature branch... it pushed to develop!! 😱 (how I don't know since its branch protected!?) I didn't want to re-write history so I reverted but it turns out reverting isn't actually undoing the commit, it undoes the data changes but its not undo since it doesn't undo the effects of a commit on the repository history! So my diff wasn't showing the new files. I've reverted the revert, rebased develop onto my feature branch and squashed all the commits so that it now appears as an actual change as the SHA ID's are different now!Pretty much all I'm adding here is a Dockerfile and some tweaks to the seed file to make it more flexible depending on the type of environment you're creating.