Skip to content

Conversation

@apricot13
Copy link
Member

Ok, so, I made a bit of a mess with all this - but this should be the one we want! 😂

Initially I merged in the rails 7 work as part of the containerisation since we'd be testing extensively as part of the release. I also thought it would help solve the webpacker issue. I've since realised it doesn't actually solve that issue and may cause the oauth functionality to break so I created a new version of the container without the rails 7 commits to be on the safe side.

Which would make the commit cleaner except...

I'm trying out tower to manage all my 1000 repos, but for some reason it had HEAD set as develop (even though it totally didn't!) so when I went to push to my nice feature branch... it pushed to develop!! 😱 (how I don't know since its branch protected!?) I didn't want to re-write history so I reverted but it turns out reverting isn't actually undoing the commit, it undoes the data changes but its not undo since it doesn't undo the effects of a commit on the repository history! So my diff wasn't showing the new files. I've reverted the revert, rebased develop onto my feature branch and squashed all the commits so that it now appears as an actual change as the SHA ID's are different now!

Pretty much all I'm adding here is a Dockerfile and some tweaks to the seed file to make it more flexible depending on the type of environment you're creating.

@alexwybraniec
Copy link

Hello @apricot13, related (but also not related) to this PR, but can you expand on what the webpacker issue is? I've been trying to get the develop branch of Outpost to run locally, and found I was hitting errors when trying to start the app using the instructions in the docs. The errors seem to be related to webpacker, and can be fixed by running webpacker:install and webpacker:compile before and after npm i && yarn install.

Thanks in advance
Alex W

@apricot13
Copy link
Member Author

Hello @apricot13, related (but also not related) to this PR, but can you expand on what the webpacker issue is? I've been trying to get the develop branch of Outpost to run locally, and found I was hitting errors when trying to start the app using the instructions in the docs. The errors seem to be related to webpacker, and can be fixed by running webpacker:install and webpacker:compile before and after npm i && yarn install.

Thanks in advance Alex W

hey @alexwybraniec you can find some more information here - its a bit of a chicken and egg! As of 7.0 rails the webpacker gem has been deprecated and the version of webpacker we're using at the moment uses webpack version 4 which has also been deprecated!

@apricot13
Copy link
Member Author

Closing in favour of the feature/rails-6-containerisation branch #287

@apricot13 apricot13 closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants