Expose sort and custom queries (instead of using QueryParser)#20
Open
casperc wants to merge 1 commit intoweavejester:masterfrom
Open
Expose sort and custom queries (instead of using QueryParser)#20casperc wants to merge 1 commit intoweavejester:masterfrom
casperc wants to merge 1 commit intoweavejester:masterfrom
Conversation
1) It is possible to pass a sort to the search function to have the output sorted. A utility function for creating the most common sorts is provided but it is also possible to create a sort manually and pass it to search. 2) It is possible to pass the search function an instantiated query rather than a string to bypass the query parser. Passing a string works as expected.
Author
|
PR #19 gives about the same functionality as the first part of my PR, it's a matter of how you want to do it. I prefer the above as it allows the user to bypass the wrapper and make the Sort himself if what the utility function for creating sorts is not sufficient, e.g. creating a custom sort. 2 does pretty much the same, it gives the user the ability make his own query if what the queryparser provides is not enough, rather than preventing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces two new features:
It is possible to pass a sort to the search function to have the output sorted. A utility function for creating the most common sorts is provided but it is also possible to create a sort manually and pass it to search.
It is possible to pass the search function an instantiated query rather than a string to bypass the query parser. Passing a string works as expected.