[eme] Keystatuses test #3490
Merged
[eme] Keystatuses test #3490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Reviewers for this pull request are: @ddorwin. |
| var expected = [{ key: key1String, value: 'usable'}, { key: key2String, value: 'usable'}].sort( lexicographicalkey ); | ||
| assert_object_equals(result, | ||
| expected, | ||
| 'keyStatuses fails'); |
Contributor
There was a problem hiding this comment.
Can the assert text here be made more explicit? Instead of 'keystatuses fails', could it say 'keystatuses should return usable' or something like that?
I will mark other examples of this below.
Contributor
There was a problem hiding this comment.
I believe there are text strings for asserts in utils.js that would need to be updated for consistency as well.
Contributor
|
Comments from us are complete. Assert text could be more specific in some instances and assert_object_equals appears to be in the process of being removed from testharness. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.