Skip to content

[BUGFIX] DPL-151: Mitigate "Undefined array key" in "LanguageService" #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbuerk merged 1 commit into from
Dec 18, 2025
Merged

[BUGFIX] DPL-151: Mitigate "Undefined array key" in "LanguageService" #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Classes/Service/LanguageService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ public function getTargetLanguageForRephrasing(SiteInterface $site, int $targetL
{
$targetLanguage = $site->getLanguageById($targetLanguage);
$targetLanguageConfiguration = $targetLanguage->toArray();
$deeplWriteLanguage = $targetLanguageConfiguration['deeplWriteLanguage'];

$deeplWriteLanguage = (string)($targetLanguageConfiguration['deeplWriteLanguage'] ?? '');
return RephraseSupportedDeepLLanguage::tryFrom($deeplWriteLanguage);
}
}
4 changes: 4 additions & 0 deletions Tests/Functional/Service/DeeplServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@

final class DeeplServiceTest extends AbstractDeepLTestCase
{
protected array $coreExtensionsToLoad = [
'typo3/cms-setup',
];

protected array $testExtensionsToLoad = [
'web-vision/deepl-base',
'web-vision/deepl-write',
Expand Down
164 changes: 164 additions & 0 deletions Tests/Functional/Service/LanguageServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,164 @@
<?php

declare(strict_types=1);

namespace WebVision\DeeplWrite\Tests\Functional\Service;

use PHPUnit\Framework\Attributes\Test;
use TYPO3\CMS\Core\Site\Entity\Site;
use WebVision\DeeplWrite\Service\LanguageService;
use WebVision\DeeplWrite\Tests\Functional\Helper\AbstractDeepLTestCase;

final class LanguageServiceTest extends AbstractDeepLTestCase
{
protected array $coreExtensionsToLoad = [
'typo3/cms-setup',
];

protected array $testExtensionsToLoad = [
'web-vision/deepl-base',
'web-vision/deepl-write',
];

protected array $configurationToUseInTestInstance = [
'EXTENSIONS' => [
'deepl_write' => [
'apiKey' => 'mock_server',
],
],
];

#[Test]
public function getTargetLanguageForRephrasingReturnsNullIfDeeplWriteLanguageDoesNotExistsInSiteConfig(): void
{
$site = new Site(
identifier: 'dummy',
rootPageId: 1,
configuration: [
'languages' => [
[
'languageId' => 0,
'enabled' => true,
'title' => 'English',
'base' => '/',
'locale' => 'en_US.UTF-8',
'navigationTitle' => 'English',
'flag' => 'us',
'typo3Language' => 'default',
'iso-639-1' => 'en',
'hreflang' => 'en-us',
'direction' => 'ltr',
'websiteTitle' => '',
],
[
'languageId' => 1,
'enabled' => true,
'title' => 'Deutsch',
'base' => '/de/',
'locale' => 'de_DE.UTF-8',
'navigationTitle' => 'English',
'flag' => 'us',
'typo3Language' => 'de',
'iso-639-1' => 'de',
'hreflang' => 'de-de',
'direction' => 'ltr',
'websiteTitle' => '',
],
],
],
settings: null,
);
$targetSite = $this->get(LanguageService::class)->getTargetLanguageForRephrasing($site, 1);
static::assertNull($targetSite);
}

#[Test]
public function getTargetLanguageForRephasingReturnsNullForInvalidConfiguredDeeplWriteLanguage(): void
{
$site = new Site(
identifier: 'dummy',
rootPageId: 1,
configuration: [
'languages' => [
[
'languageId' => 0,
'enabled' => true,
'title' => 'English',
'base' => '/',
'locale' => 'en_US.UTF-8',
'navigationTitle' => 'English',
'flag' => 'us',
'typo3Language' => 'default',
'iso-639-1' => 'en',
'hreflang' => 'en-us',
'direction' => 'ltr',
'websiteTitle' => '',
],
[
'languageId' => 1,
'enabled' => true,
'title' => 'Deutsch',
'base' => '/de/',
'locale' => 'de_DE.UTF-8',
'navigationTitle' => 'English',
'flag' => 'us',
'typo3Language' => 'de',
'iso-639-1' => 'de',
'hreflang' => 'de-de',
'direction' => 'ltr',
'websiteTitle' => '',
'deeplWriteLanguage' => 'RU',
],
],
],
settings: null,
);
$targetSite = $this->get(LanguageService::class)->getTargetLanguageForRephrasing($site, 1);
static::assertNull($targetSite);
}

#[Test]
public function getTargetLanguageForRephrasingReturnsValidConfiguredDeeplWriteLanguage(): void
{
$site = new Site(
identifier: 'dummy',
rootPageId: 1,
configuration: [
'languages' => [
[
'languageId' => 0,
'enabled' => true,
'title' => 'English',
'base' => '/',
'locale' => 'en_US.UTF-8',
'navigationTitle' => 'English',
'flag' => 'us',
'typo3Language' => 'default',
'iso-639-1' => 'en',
'hreflang' => 'en-us',
'direction' => 'ltr',
'websiteTitle' => '',
],
[
'languageId' => 1,
'enabled' => true,
'title' => 'Deutsch',
'base' => '/de/',
'locale' => 'de_DE.UTF-8',
'navigationTitle' => 'English',
'flag' => 'us',
'typo3Language' => 'de',
'iso-639-1' => 'de',
'hreflang' => 'de-de',
'direction' => 'ltr',
'websiteTitle' => '',
'deeplWriteLanguage' => 'DE',
],
],
],
settings: null,
);
$targetSite = $this->get(LanguageService::class)->getTargetLanguageForRephrasing($site, 1);
static::assertSame('DE', $targetSite);
}
}