Add override_block_rules parameter to windows_firewall_rule#39
Open
sbrito85 wants to merge 2 commits intowebalexeu:mainfrom
Open
Add override_block_rules parameter to windows_firewall_rule#39sbrito85 wants to merge 2 commits intowebalexeu:mainfrom
sbrito85 wants to merge 2 commits intowebalexeu:mainfrom
Conversation
webalexeu
requested changes
Aug 12, 2025
Owner
webalexeu
left a comment
webalexeu
left a comment
There was a problem hiding this comment.
Can you please review and also update the documentation using puppet strings ?
Thank you for your work, I will finish the review later this week
webalexeu
requested changes
Aug 28, 2025
Owner
webalexeu
left a comment
webalexeu
left a comment
There was a problem hiding this comment.
Please fix those last comments
I will release a version afer this review
| DisplayName = $DisplayName; | ||
| Description = $Description; | ||
| Action = $Action; | ||
| Action = $Action; |
Owner
There was a problem hiding this comment.
Please remove the unnecessary spaces
| $params.Add("Direction", $Direction) | ||
| } | ||
| if ($OverrideBlockRules) { | ||
| $params.Add("OverrideBlockRules", [bool]$OverrideBlockRules) |
Owner
There was a problem hiding this comment.
Please don't force the type
It will need to be aligned globally to set types on all resources
| $params.Add("Direction", $Direction) | ||
| } | ||
| if ($OverrideBlockRules) { | ||
| $params.Add("OverrideBlockRules", [bool]$OverrideBlockRules) |
Owner
There was a problem hiding this comment.
Please don't force the type
It will need to be aligned globally to set types on all resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the ability to set OverrideBlockRules in firewall rules
Additional Context
Add any additional context about the problem here.
We previously did not have the ability to change this setting. Adding that feature here.
Related Issues (if any)
#38
Checklist
windows_firewall_rule { 'Test Rule':
ensure => 'present',
action => 'allow',
authentication => 'required',
override_block_rules => 'true',
description => 'test rule',
direction => 'outbound',
edge_traversal_policy => 'block',
enabled => 'false',
remote_port => '9999',
protocol => 'tcp',
profile => ['domain', 'private'],
}