Make ANGLE compile successfully with the other backends #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra semicolon warning error is fixed in latest shaderc, and it's a third party of dawn. So we have to move shaderc to upper folder, and maintain shaderc by Aquarium. This patch also add .gitattributes file to specify format of files because the ending of line should be specified to LF, otherwise it will become CRLF on Windows.
Update shaderc to latest commit
…ution This patch makes ANGLE backend build with the other backends and removes standalone ANGLE build. First, solve conflict of ANGLE, dawn and d3d12 backend EGLWindow.h is from angle util, which causes microsoft namespace can't be find. However, EGLWindow isn't used at all by Aquarium, so the header should be removed. Second, solve conflict of ANGLE and OpenGL backend 1.Write own own gl header and gl functions 2.Load ANGLE dll on Windows by GetProcAddress 3.Load OpenGL dll by glfwGetProcAddress 4.Replace gl library of imgui by our own library 5.The egl headers of ANGLE isn't conflict with GL functions, so egl headers are maintained. Third, Update README.md and Build.gn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes ANGLE backend build with the other backends and removes standalone
ANGLE build.
First, solve conflict of ANGLE, dawn and d3d12 backend
EGLWindow.h is from angle util, which causes microsoft namespace
can't be find. However, EGLWindow isn't used at all by Aquarium,
so the header should be removed.
Second, solve conflict of ANGLE and OpenGL backend
1.Write own own gl header and gl functions
2.Load ANGLE dll on Windows by GetProcAddress
3.Load OpenGL dll by glfwGetProcAddress
4.Replace gl library of imgui by our own library
5.The egl headers of ANGLE isn't conflict with GL functions, so egl
headers are maintained.
Third, Update README.md and Build.gn