-
Notifications
You must be signed in to change notification settings - Fork 349
Use GPUBuffer in GPUBindingResource #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use GPUBuffer in GPUBindingResource #514
Conversation
|
FYI It requires gpuweb/types#182 |
kainino0x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but marking draft as we need to wait until all browsers support this.
|
Thanks for this PR. I like this new style! Agree with @kainino0x, we shouldn't merge this until all browsers support it and it's shipped in Chrome stable, and maybe given it 2+ weeks or after that. |
|
@jimblandy @mwyrzykowski Are there existing browser bugs/tickets I can follow to keep track of those changes? |
Yes, WebKit bug is https://bugs.webkit.org/show_bug.cgi?id=294006 @beaufortfrancois |
greggman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@jimblandy @mwyrzykowski Did Firefox and Safari implement this change? If so, I'l update our WebGPU samples with that PR. |
|
https://webgpureport.org/ shows a warning if it's not implemented. From that
|
|
Thanks @greggman! Let's wait until it reaches Safari Stable then. |
|
WebKit has @beaufortfrancois :) |
|
@greggman did you try Safari 26.2? |
|
@mwyrzykowski, my Mac had not told me to upgrade yet 😄 . I updated to MacOS 26.2 and can verify that Safari 26.2 supports this. tangential question: Safari TP no longer supports WebGPU on MacOS 15 right, or at least it stopped working for me. My work machine is still MacOS 15.7.3, my personal machine is now 26.2. I have not been able to use Safari TP on MacOS 15 to test WebGPU for a month or 2. Is that expected? As for this PR. We might want to give it a couple of weeks to let more people update to 26.2 before breaking it for people still on < 26.2. |
That's correct, it was disabled with https://bugs.webkit.org/show_bug.cgi?id=299237 since we removed some underlying framework workarounds for OS versions < 26.0
Sounds good to me 👍 |
Spec PR: gpuweb/gpuweb#5193