Skip to content

Conversation

@beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented May 22, 2025

@beaufortfrancois beaufortfrancois marked this pull request as draft May 22, 2025 08:29
@beaufortfrancois
Copy link
Collaborator Author

FYI It requires gpuweb/types#182

@beaufortfrancois beaufortfrancois marked this pull request as ready for review May 28, 2025 09:35
@beaufortfrancois beaufortfrancois requested a review from greggman May 28, 2025 09:37
@kainino0x kainino0x marked this pull request as draft June 3, 2025 21:27
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but marking draft as we need to wait until all browsers support this.

@greggman
Copy link
Collaborator

greggman commented Jun 3, 2025

Thanks for this PR. I like this new style!

Agree with @kainino0x, we shouldn't merge this until all browsers support it and it's shipped in Chrome stable, and maybe given it 2+ weeks or after that.

@beaufortfrancois
Copy link
Collaborator Author

FYI @jimblandy @mwyrzykowski

@beaufortfrancois
Copy link
Collaborator Author

@jimblandy @mwyrzykowski Are there existing browser bugs/tickets I can follow to keep track of those changes?

@mwyrzykowski
Copy link
Contributor

@jimblandy @mwyrzykowski Are there existing browser bugs/tickets I can follow to keep track of those changes?

Yes, WebKit bug is https://bugs.webkit.org/show_bug.cgi?id=294006 @beaufortfrancois

Copy link
Collaborator

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@beaufortfrancois
Copy link
Collaborator Author

@jimblandy @mwyrzykowski Did Firefox and Safari implement this change? If so, I'l update our WebGPU samples with that PR.

@greggman
Copy link
Collaborator

https://webgpureport.org/ shows a warning if it's not implemented. From that

  • firefox stable has implemented it
  • Safari stable has not
  • Safari Technology Preview has

@beaufortfrancois
Copy link
Collaborator Author

Thanks @greggman! Let's wait until it reaches Safari Stable then.

@mwyrzykowski
Copy link
Contributor

WebKit has @beaufortfrancois :)

@mwyrzykowski
Copy link
Contributor

@greggman did you try Safari 26.2?

@greggman
Copy link
Collaborator

greggman commented Dec 19, 2025

@mwyrzykowski, my Mac had not told me to upgrade yet 😄 . I updated to MacOS 26.2 and can verify that Safari 26.2 supports this.

tangential question: Safari TP no longer supports WebGPU on MacOS 15 right, or at least it stopped working for me. My work machine is still MacOS 15.7.3, my personal machine is now 26.2. I have not been able to use Safari TP on MacOS 15 to test WebGPU for a month or 2. Is that expected?

As for this PR. We might want to give it a couple of weeks to let more people update to 26.2 before breaking it for people still on < 26.2.

@mwyrzykowski
Copy link
Contributor

tangential question: Safari TP no longer supports WebGPU on MacOS 15 right, or at least it stopped working for me. My work machine is still MacOS 15.7.3, my personal machine is now 26.2. I have not been able to use Safari TP on MacOS 15 to test WebGPU for a month or 2. Is that expected?

That's correct, it was disabled with https://bugs.webkit.org/show_bug.cgi?id=299237 since we removed some underlying framework workarounds for OS versions < 26.0

As for this PR. We might want to give it a couple of weeks to let more people update to 26.2 before breaking it for people still on < 26.2.

Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants