fix: missing escape column name for SQL query clauses#169
Merged
lex148 merged 2 commits intoweldsorm:mainfrom Jan 10, 2026
Merged
fix: missing escape column name for SQL query clauses#169lex148 merged 2 commits intoweldsorm:mainfrom
lex148 merged 2 commits intoweldsorm:mainfrom
Conversation
Contributor
|
Very nice! I have been testing this and all looks good. merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my database I had a column named
order(reserved keyword). This caused all queries involving it to fail.This PR:
ColumnWriterandexcapeas was the case in other places.Hopefully I did not miss any non-escaped column names.
With this PR merged + sync I should be able to fully use
weldswith my existing db!