Open
Conversation
error: variable 'minutes' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] This points out a rare edge case that "rest" isn't passed and minutes is initialized to garbage like 4123476234. We might set downtime to a longer than expected interval if this happened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to compile this with clang on OS X and hit a few issues.
The commit messages contain more detail, but the highlights are:
-I/usr/local/nagios/includeto compile because I installed from source.clangseems to need-D_XOPEN_SOURCE=600to give youstrdupwith-std=c99.mallocdoesn'tcallocby default